Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that identity matchers only work with reference types #299

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Make it clear that identity matchers only work with reference types #299

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df59e5d
Make it clear that identity matchers only work with reference types
lukeredpath Jun 2, 2016
48215ab
Syntax highlight function name
lukeredpath Jun 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,9 @@ expect(actual).toNot(beIdenticalTo(expected))
expect(actual) !== expected
```

Its important to remember that beIdenticalTo only makes sense when comparing types with reference semantics, which have a notion of identity. In Swift, that means a `class`. This matcher will not work with types with value semantics such as `struct` or `enum`. If you need to compare two value types, you can either compare individual properties or if it makes sense to do so, make your type implement `Equatable` and use Nimble's equivalence matchers instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do you think it makes sense to have "beIdenticalTo" as "beIdenticalTo"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I missed that one.



```objc
// Objective-C

Expand Down