Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Migrate to Swift 4.1 and drop Swift 3.x support #515

Merged
merged 4 commits into from
Apr 11, 2018
Merged

[BREAKING] Migrate to Swift 4.1 and drop Swift 3.x support #515

merged 4 commits into from
Apr 11, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Apr 11, 2018

Ref: #514

@ikesyo ikesyo added this to the v8.0.0 milestone Apr 11, 2018
@ikesyo
Copy link
Member Author

ikesyo commented Apr 11, 2018 •
edited
Loading

https://travis-ci.org/Quick/Nimble/jobs/364948714

 -> Nimble (7.1.0)
    - ERROR | swift: Specification `Nimble` specifies an inconsistent `swift_version` (`4.0`) compared to the one present in your `.swift-version` file (`4.1`). Please remove the `.swift-version` file which is now deprecated and only use the `swift_version` attribute within your podspec.

This is annoying... .swift-version is for swiftenv, not for CocoaPods. 😕

EDITED: This will not be an issue once CocoaPods 1.6.0 is released. CocoaPods/CocoaPods#7436

@ikesyo
Copy link
Member Author

ikesyo commented Apr 11, 2018

@Quick/core Please review 🙏

@ashfurrow
Copy link
Member

Looks good to me 👍

phatblat
phatblat approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this get cleaned up 👌🏻

@wongzigii
Copy link
Member

🚢 Let's get rid of the (swift>= 4.0) version check.

@wongzigii wongzigii merged commit 95c09b8 into master Apr 11, 2018
@wongzigii wongzigii deleted the swift-4.1 branch April 11, 2018 16:14
@ikesyo
Copy link
Member Author

ikesyo commented Apr 11, 2018

Thanks all! 🎉

@phatblat phatblat mentioned this pull request Apr 14, 2018
Closed
@ikesyo ikesyo mentioned this pull request Apr 23, 2018
Merged
@ikesyo ikesyo mentioned this pull request Aug 20, 2018
Merged
@ikesyo ikesyo mentioned this pull request Feb 9, 2019
Merged
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
@wongzigii
Merge pull request Quick#515 from Quick/swift-4.1
b424c3e 
[BREAKING] Migrate to Swift 4.1 and drop Swift 3.x support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatblat phatblat phatblat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ikesyo @ashfurrow @wongzigii @phatblat