Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce NMBObjCMatcher usages #592

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Reduce NMBObjCMatcher usages #592

merged 1 commit into from
Aug 20, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Aug 8, 2018

Related to #546.

@ikesyo ikesyo added this to the v8.0.0 milestone Aug 8, 2018
@ikesyo ikesyo requested a review from a team August 8, 2018 17:19
sharplet
sharplet reviewed Aug 19, 2018
View reviewed changes
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Are we accepting breaking changes on master at this stage?

@ikesyo
Copy link
Member Author

ikesyo commented Aug 20, 2018

Yes we are, see #514 and #515 for the details.

@ikesyo ikesyo merged commit d499063 into master Aug 20, 2018
@ikesyo ikesyo deleted the reduce-nmbobjcmatcher-usages branch August 20, 2018 13:35
@ikesyo ikesyo mentioned this pull request Sep 6, 2018
Merged
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
@ikesyo
Merge pull request Quick#592 from Quick/reduce-nmbobjcmatcher-usages
83718a4 
Reduce NMBObjCMatcher usages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharplet sharplet sharplet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ikesyo @sharplet