Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable same-name proposal on non hashed mappings #629

Merged
merged 3 commits into from
Aug 20, 2024
Merged

enable same-name proposal on non hashed mappings #629

merged 3 commits into from
Aug 20, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Aug 17, 2024 •
edited
Loading

and delete a lot of "mark as deobf" mappings. i built this feature ages ago so we'd stop doing that and never turned it on

  • removes "file not mapping a class" error. it's a good idea, but doesn't support name proposal

@ix0rai ix0rai added t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft reviews needed please review this PR s: medium PRs with less than 700 lines and more than 200 labels Aug 17, 2024
@ix0rai ix0rai requested a review from OroArmor August 19, 2024 23:38
@ix0rai ix0rai requested a review from OroArmor August 20, 2024 03:48
@ix0rai ix0rai added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Aug 20, 2024
@ix0rai ix0rai merged commit 5f22059 into QuiltMC:24w33a Aug 20, 2024
3 checks passed
@ix0rai ix0rai mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OroArmor OroArmor OroArmor approved these changes

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
final-comment-period is approved and will soon be merged if no issues are raised s: medium PRs with less than 700 lines and more than 200 t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ix0rai @supersaiyansubtlety @OroArmor