toss a lot of redundant mappings #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix0rai
added
t: toolchain
OroArmor
requested changes
Aug 20, 2024
OroArmor
reviewed
Aug 20, 2024
| @@ -14,7 +14,6 @@ CLASS net/minecraft/unmapped/C_oddtxnnw net/minecraft/client/render/entity/Entit | |||
| ARG 2 tickDelta | |||
| METHOD m_gkfhbwdx getPositionOffset (Lnet/minecraft/unmapped/C_vptppxob;)Lnet/minecraft/unmapped/C_vgpupfxx; | |||
| METHOD m_hknkoqwr getTexture (Lnet/minecraft/unmapped/C_vptppxob;)Lnet/minecraft/unmapped/C_ncpywfca; | |||
| METHOD m_idqrsxfa (Lnet/minecraft/unmapped/C_vptppxob;)F | |||
There was a problem hiding this comment.
This is something to look into for the javadocs:
supersaiyansubtlety
requested changes
Aug 21, 2024
|
adding suggestions individually because the file tab is huge. sorry |
Co-authored-by: Will <supersaiyansubtlety@gmail.com>
Co-authored-by: Eli Orona <eliorona@live.com>
Co-authored-by: Eli Orona <eliorona@live.com>
Co-authored-by: Eli Orona <eliorona@live.com>
Co-authored-by: Eli Orona <eliorona@live.com>
Co-authored-by: Eli Orona <eliorona@live.com>
Co-authored-by: Will <supersaiyansubtlety@gmail.com>
supersaiyansubtlety
requested changes
Aug 21, 2024
OroArmor
added
the
update-base
|
🚨 Target branch is already set to 24w33a |
github-actions
bot
removed
the
update-base
OroArmor
added
the
update-base
|
🚀 Target branch has been updated to 24w34a |
|
🚨 Please fix merge conflicts before this can be merged |
github-actions
bot
added
outdated
…pings # Conflicts: # mappings/com/mojang/blaze3d/platform/GlStateManager.mapping # mappings/com/mojang/blaze3d/shader/GlUniform.mapping # mappings/com/mojang/blaze3d/systems/RenderSystem.mapping # mappings/net/minecraft/client/gl/JsonEffectGlShader.mapping # mappings/net/minecraft/client/gl/PostProcessShader.mapping # mappings/net/minecraft/client/gl/ShaderEffect.mapping # mappings/net/minecraft/client/render/BufferBuilderStorage.mapping # mappings/net/minecraft/client/render/RenderLayer.mapping # mappings/net/minecraft/client/render/ShaderProgram.mapping # mappings/net/minecraft/world/storage/StorageIoWorker.mapping
This reverts commit 3fdbc96.
ix0rai
removed
the
outdated
supersaiyansubtlety
approved these changes
Aug 23, 2024
OroArmor
requested changes
Aug 24, 2024
Co-authored-by: Eli Orona <eliorona@live.com>
OroArmor
approved these changes
Aug 26, 2024
OroArmor
added
final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a follow-up to #629