fix: wrap parsing with try catch statements

[mamadoudicko]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 4, 2023 9:25am
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 4, 2023 9:25am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 4, 2023 9:25am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatDialogueArea/components/ChatDialogue/components/ChatNotification/components/NotificationDisplayer/NotificationDisplayer.tsx

The code seems to be well written and follows the SOLID principles. However, there are a few areas that could be improved for better readability and error handling:

1. Error Handling: In the try-catch block, the error is caught but not handled or logged. This could make debugging difficult if the JSON.parse operation fails. Consider logging the error or handling it appropriately.

   try {
     const parsedMessage = JSON.parse(nonParsedMessage) as NotificationMessage;
     message = parsedMessage.message;
     status = parsedMessage.status;
     name = parsedMessage.name;
   } catch (error) {
     console.error(error);
     return <Fragment />;
   }

2. Nullish Coalescing: Instead of checking for null or undefined with nonParsedMessage === null || nonParsedMessage === undefined, consider using the nullish coalescing operator (??) for cleaner code.

   const nonParsedMessage = content.message ?? <Fragment />;

3. Type Safety: The nonParsedMessage is directly parsed without any type checking. If the nonParsedMessage is not a valid JSON string, it will throw an error. Consider adding a type check before parsing.

   if (typeof nonParsedMessage === 'string') {
     const parsedMessage = JSON.parse(nonParsedMessage) as NotificationMessage;
     // ...
   }

---

🐛🔍👍

---

Powered by Code Review GPT