-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 ↕️ 📱height now matches mobile height #1323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/Sidebar/Sidebar.tsx The changes in this file are also related to styling, but there's a bit more logic involved. The const handleDragEnd = (event, info) => {
if (info.offset.x > 100 && !open) {
setOpen(true);
} else if (info.offset.x < -100 && open) {
setOpen(false);
}
};
// then in the component
onDragEnd={handleDragEnd} This way, the drag end logic is separated from the component, making it easier to read and test. 📁💡🐛 Powered by Code Review GPT |
🤖 I have created a release *beep* *boop* --- ## 0.0.88 (2023-10-05) ## What's Changed * fix: wrap parsing with try catch statements by @mamadoudicko in #1321 * fix: 🐛↕️ 📱height now matches mobile height by @matthieujacq in #1323 * feat: add onboarding step 3 by @mamadoudicko in #1324 * feat: restructure the sidebar of the brains management page by @matthieujacq in #1325 * feat: add onboarding table by @mamadoudicko in #1327 * feat: update onboarding controller and fix typo by @mamadoudicko in #1333 **Full Changelog**: v0.0.87...v0.0.88 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## 0.0.88 (2023-10-05) ## What's Changed * fix: wrap parsing with try catch statements by @mamadoudicko in QuivrHQ/quivr#1321 * fix: 🐛↕️ 📱height now matches mobile height by @matthieujacq in QuivrHQ/quivr#1323 * feat: add onboarding step 3 by @mamadoudicko in QuivrHQ/quivr#1324 * feat: restructure the sidebar of the brains management page by @matthieujacq in QuivrHQ/quivr#1325 * feat: add onboarding table by @mamadoudicko in QuivrHQ/quivr#1327 * feat: update onboarding controller and fix typo by @mamadoudicko in QuivrHQ/quivr#1333 **Full Changelog**: QuivrHQ/quivr@v0.0.87...v0.0.88 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Issue
#1320
Description
The UI now fit the screen's height on smartphones.
Solution
Creation of a new utility class
.h-fill-available
.Uses
cqh
(container query height) supported by chrome orsvh
(for safari). (see: tailwindlabs/tailwindcss#4515 (comment))Screenshots (if appropriate):
Before
After