Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api_brain_definition table #1601

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Nov 7, 2023

Issue: #1549

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Nov 7, 2023
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 11:30am
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 11:30am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 11:30am

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/backend/repository/api_brain_definition/add_api_brain_definition.py

The add_api_brain_definition function does not return any value or feedback about the operation's success or failure. It would be helpful to return a success message or the created object, or in case of an error, an appropriate error message.


Risk Level 3 - /home/runner/work/quivr/quivr/backend/models/databases/supabase/api_brain_definition.py

The add_api_brain_definition method does not handle exceptions. It's recommended to add error handling to prevent the application from crashing in case of an error. For example:

try:
    response = self.db.table(\"api_brain_definition\").insert(
        [{\"brain_id\": str(brain_id), **config.dict()}]
    )
except Exception as e:
    print(f\"An error occurred: {e}\")
    return None

Risk Level 5 - /home/runner/work/quivr/quivr/backend/models/ApiBrainDefinition.py

The secrets field in the ApiBrainDefinition class is a security risk. Secrets should not be stored in plain text. Consider using a secure method to store and retrieve secrets.


🔧💬🔒


Powered by Code Review GPT

mamadoudicko pushed a commit that referenced this pull request Nov 8, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.108 (2023-11-07)

## What's Changed
* feat: add api_brain_definition table by @mamadoudicko in
#1601
* feat: add brain_type column to brain table by @mamadoudicko in
#1603
* feat: supabase vault by @gozineb in
#1605


**Full Changelog**:
v0.0.107...v0.0.108

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.108 (2023-11-07)

## What's Changed
* feat: add api_brain_definition table by @mamadoudicko in
QuivrHQ/quivr#1601
* feat: add brain_type column to brain table by @mamadoudicko in
QuivrHQ/quivr#1603
* feat: supabase vault by @gozineb in
QuivrHQ/quivr#1605


**Full Changelog**:
QuivrHQ/quivr@v0.0.107...v0.0.108

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants