Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add brain_type column to brain table #1603

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Nov 7, 2023

Issue: #1601

Demo:

Screen.Recording.2023-11-07.at.11.55.02.mp4

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Nov 7, 2023
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 3:18pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 3:18pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 3:18pm

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/backend/models/databases/supabase/brains.py

The code changes in this file are also minimal and seem to be adding the new BrainType to the CreateBrainProperties class. However, the default value for brain_type is set to BrainType.DOC. If BrainType.DOC is not a valid value, this could potentially cause issues. It would be safer to set the default value to None and handle the case where brain_type is None in the code that uses this class.

brain_type: Optional[BrainType] = None

🧠📝⚠️


Powered by Code Review GPT

@mamadoudicko mamadoudicko merged commit dd2bc1f into main Nov 7, 2023
7 of 8 checks passed
mamadoudicko pushed a commit that referenced this pull request Nov 8, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.108 (2023-11-07)

## What's Changed
* feat: add api_brain_definition table by @mamadoudicko in
#1601
* feat: add brain_type column to brain table by @mamadoudicko in
#1603
* feat: supabase vault by @gozineb in
#1605


**Full Changelog**:
v0.0.107...v0.0.108

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.108 (2023-11-07)

## What's Changed
* feat: add api_brain_definition table by @mamadoudicko in
QuivrHQ/quivr#1601
* feat: add brain_type column to brain table by @mamadoudicko in
QuivrHQ/quivr#1603
* feat: supabase vault by @gozineb in
QuivrHQ/quivr#1605


**Full Changelog**:
QuivrHQ/quivr@v0.0.107...v0.0.108

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants