Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird notification bug #242

Closed
atruskie opened this issue Nov 17, 2015 · 3 comments
Closed

Weird notification bug #242

atruskie opened this issue Nov 17, 2015 · 3 comments
Labels
bug help wanted triage:low

Comments

@atruskie
Copy link
Member

A notification is showing on the main website page that simply states 'true'. Happens when a session is expired. See screenshot:

https://gyazo.com/3efef10f471c57218a0b434c2f28e911
@atruskie
Copy link
Member Author

atruskie commented Jan 5, 2017

Finally worked out the cause of this: heartcombo/devise#1777

atruskie added a commit that referenced this issue Jan 12, 2017
@atruskie
Fix true flash messages on session time out
93b47f9 
Fixes #242

Also adds a `data-message-type` attribute to the alert DOM to make
future debugging of flashes easier.
@AbeCole
Copy link

AbeCole commented Jan 12, 2017 •
edited
Loading

If your echoing out the message and having an issue with this 'true' text being displayed, I used the following solution to reduce the standard flash array to only items whose value is a String:

flash.select { |m| m[1].is_a?(String) }

@atruskie
Copy link
Member Author

Thank you for the tip.

However, we already fixed this in a branch, see: 93b47f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted triage:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AbeCole @atruskie