Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rex_text or UITextField is not called when it is cleared #129

Closed
Igor-Palaguta opened this issue Jun 8, 2016 · 4 comments
Closed

rex_text or UITextField is not called when it is cleared #129

Igor-Palaguta opened this issue Jun 8, 2016 · 4 comments

Comments

@Igor-Palaguta
Copy link

rex_text filters nil values, so it does not send any value when text is erased in UITextField
@neilpa
Copy link
Member

neilpa commented Jun 8, 2016

Resolving #125 should cover this as well, right?

dmcrodrigues added a commit to dmcrodrigues/Rex that referenced this issue Jul 2, 2016
@dmcrodrigues
Changed rex_text bindable property to be an optional string
82bccfd 
Fixes RACCommunity#125, RACCommunity#129.
@dmcrodrigues dmcrodrigues mentioned this issue Jul 2, 2016
Merged
RuiAAPeres pushed a commit that referenced this issue Jul 5, 2016
@dmcrodrigues @RuiAAPeres
Changed rex_text bindable property to be an optional string (#133)
0a1927d 
* Changed `rex_text` bindable property to be an optional string

Fixes #125, #129.

* Updated UILabel's text property test to include nullability
@dmcrodrigues
Copy link
Contributor

This should be fixed with #133.

@neilpa neilpa closed this as completed Jul 5, 2016
@Igor-Palaguta
Copy link
Author

Not sure that it is fixed, UITextField still returns not optional text, filtering nil values

dmcrodrigues added a commit to dmcrodrigues/Rex that referenced this issue Jul 6, 2016
@dmcrodrigues
Fixes RACCommunity#129 - UITextField's text bindable property should …
5123869 
…be of optional type
@dmcrodrigues
Copy link
Contributor

You're correct. I included this change in #119.

@dmcrodrigues dmcrodrigues reopened this Jul 6, 2016
dmcrodrigues added a commit to dmcrodrigues/Rex that referenced this issue Jul 6, 2016
@dmcrodrigues
Fixes RACCommunity#129 - UITextField's text bindable property should …
98d4932 
…be of optional type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilpa @Igor-Palaguta @dmcrodrigues