Changed rex_text bindable property to be an optional string
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,7 @@ class UITableViewCellTests: XCTestCase { | |||
| label.rex_text <~ | |||
| titleProperty | |||
| .producer | |||
| .map(Optional.init) // TODO: Remove in the future, binding with optionals will be available soon in RAC | |||
| .takeUntil(cell.rex_prepareForReuse) | |||
There was a problem hiding this comment.
Could you add a reference to this ("will be available soon")
There was a problem hiding this comment.
Done! I also update the test to include this behaviour.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125, #129.
Discussion
This no longer relies on KVC, I think this promotes code consistency since other properties are not using it either. It also helps avoiding a battle with a weakly typed system where everything needs to be
AnyObject.