Deallocate Trigger Signal #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// use this method to be able to expose these inherently hot streams | ||
| /// as `Signal`s. | ||
| @warn_unused_result(message="Did you forget to call `observe` on the signal?") | ||
| public func toSignalAssumingHot() -> Signal<AnyObject?, NSError> { |
There was a problem hiding this comment.
Since Signals are hot, it seems like this could just be called toSignal.
There was a problem hiding this comment.
I kept the original comments from Nacho with a slight modification, but yes I agree with your suggestion.
|
Thanks for adding these @RuiAAPeres (and thanks for the review @mdiep) |
| return self | ||
| .rex_toSignal() | ||
| .map { _ in () } | ||
| .ignoreError() |
There was a problem hiding this comment.
Does this actually ignore errors? Notice that my operators don't actually ignore unexpected errors, they assert they won't happen.
There was a problem hiding this comment.
When an error event is sent, it will complete (by default replacement == .Completed):
case .Failed:
observer.action(replacement)Your operator is slightly more aggressive.
|
Happy to see these make it to Rex :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding some of the operators @NachoSoto shared here.