Deallocate Trigger Signal #99
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // | ||
| // RACSignal.swift | ||
| // Rex | ||
| // | ||
| // Created by Rui Peres on 14/04/2016. | ||
| // Copyright © 2016 Neil Pankey. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import Result | ||
| import ReactiveCocoa | ||
|
|
||
| extension RACSignal { | ||
|
|
||
| /// Converts `self` into a `Signal`. | ||
| /// | ||
| /// Because the operator can't know whether `self` is hot or cold, | ||
| /// for certain things, like event streams (see `UIControl.signalForControlEvents`) | ||
| /// use this method to be able to expose these inherently hot streams | ||
| /// as `Signal`s. | ||
| @warn_unused_result(message="Did you forget to call `observe` on the signal?") | ||
| public func toSignalAssumingHot() -> Signal<AnyObject?, NSError> { | ||
|
There was a problem hiding this comment. Since There was a problem hiding this comment. I kept the original comments from Nacho with a slight modification, but yes I agree with your suggestion. |
||
| return Signal { observer in | ||
| return self.toSignalProducer().start(observer) | ||
| } | ||
| } | ||
|
|
||
| /// Converts `self` into a `Signal`, that can be used | ||
| /// with the `takeUntil` operator, or as an "activation" signal. | ||
| /// (e.g. a button) | ||
| @warn_unused_result(message="Did you forget to call `observe` on the signal?") | ||
| public final func toTriggerSignal() -> Signal<(), NoError> { | ||
| return self | ||
| .toSignalAssumingHot() | ||
| .map { _ in () } | ||
| .ignoreError() | ||
|
There was a problem hiding this comment. Does this actually ignore errors? Notice that my operators don't actually ignore unexpected errors, they assert they won't happen. There was a problem hiding this comment. When an error event is sent, it will complete (by default case .Failed:
observer.action(replacement)Your operator is slightly more aggressive. |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could/should be a property. It's idempotent.