Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whatsapp share functionality and minor changes #46

Merged
merged 28 commits into from
Mar 20, 2022
Merged

Conversation

RDjarbeng
Copy link
Owner

No description provided.

@netlify
Copy link

netlify bot commented Mar 2, 2022

✅ Deploy Preview for rcountdown ready!

🔨 Explore the source changes: bf6e5e5

🔍 Inspect the deploy log: https://app.netlify.com/sites/rcountdown/deploys/6237827fd1512200089835aa

😎 Browse the preview: https://deploy-preview-46--rcountdown.netlify.app

@RDjarbeng RDjarbeng added enhancement New feature or request ui / ux labels Mar 2, 2022
nyakotey and others added 4 commits March 4, 2022 14:01
* make whatsapp share into button

also testing different pc experience

* fix whatsapp share icon not displaying on some devices
testing pc and mobile sharing differences

* improve sharing differences between mobile and pc

* show whatsapp share on mobile and hide on desktop with css
fix header logo-name overflowing when small mobile device is in landscape

Co-authored-by: Richard Djarbeng <57795443+RDjarbeng@users.noreply.github.com>
added async stylesheet loading for cloudflare
@RDjarbeng RDjarbeng mentioned this pull request Mar 4, 2022
@RDjarbeng
Copy link
Owner Author

@nyakotey can merge this pull request now right?

@nyakotey
Copy link
Collaborator

nyakotey commented Mar 8, 2022

@RDjarbeng yes

@RDjarbeng
Copy link
Owner Author

RDjarbeng commented Mar 8, 2022 via email

RDjarbeng added a commit that referenced this pull request Mar 10, 2022
Shareable day of the year for mobile (Whatsapp) completed in #46
@RDjarbeng RDjarbeng merged commit 1c6ceae into listPage Mar 20, 2022
@RDjarbeng RDjarbeng deleted the whatsappShare branch March 20, 2022 21:42
@RDjarbeng RDjarbeng restored the whatsappShare branch March 20, 2022 23:55
@nyakotey nyakotey deleted the whatsappShare branch March 22, 2022 20:40
@RDjarbeng RDjarbeng restored the whatsappShare branch March 25, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui / ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants