-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lobby scene localization #1449
Merged
Merged
Lobby scene localization #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required as existing font assets do not contain glyphs for all supported languages.
(Otherwise, setting locale in build from command line wouldn't change font)
stilnat
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single change, change addressable build to default path, otherwise great work
stilnat
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds localization functionality to the Lobby scene. Text within the Lobby scene now can now be localized for English, French, Portuguese and Russian.
This PR includes:
This PR does not include:
PR checklist
Pictures/Videos)
Testing
In Play Mode in the editor, you can change the locale using the selector at the top right of the screen.
In a build, you cannot change the locale while in-game. However, you can use the provided batch files to open the game with a different locale selected. Make sure you have correctly built the Addressables before testing in a build.
Changes
Should be fairly self-explanatory and documented in git comments, but hit me up if you have questions.
Future work required
Related issues
Further contributes to the intent of #1393, building on the work completed in #1448.