Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lobby scene localization #1449

Merged
merged 20 commits into from
Aug 30, 2024
Merged

Conversation

Ryan089
Copy link
Contributor

@Ryan089 Ryan089 commented Aug 26, 2024

Summary

Adds localization functionality to the Lobby scene. Text within the Lobby scene now can now be localized for English, French, Portuguese and Russian.

This PR includes:

  • Static text localization for lobby tab descriptors and content.
  • Dynamic localization for Toggle Buttons and Round State Views.
  • LocalizeFont script to enable font to change based on selected locale.
  • A few batch files to enable testing of the build.

This PR does not include:

  • Any kind of guarantee that the translations are correct.
  • Any mechanism for changing the locale within a build (e.g. a "Select Language" menu)
  • Any second-order changes to UI elements (e.g. so translated text fits into provided text boxes)
  • Any guidance on how to get Addressables correctly functioning in this project.

PR checklist

  • The game builds properly without errors.
  • No unrelated changes are present.
  • No "trash" files are committed.
  • Relevant code is documented.

Pictures/Videos)

image

Testing

In Play Mode in the editor, you can change the locale using the selector at the top right of the screen.

In a build, you cannot change the locale while in-game. However, you can use the provided batch files to open the game with a different locale selected. Make sure you have correctly built the Addressables before testing in a build.

Changes

Should be fairly self-explanatory and documented in git comments, but hit me up if you have questions.

Future work required

  • Translations will need to be reviewed for correctness / appropriateness / tone.
  • UI may need to change to accommodate different length text. For example, on the provided image, you can see several occurrences of the text not fitting on the button or text field.

Related issues

Further contributes to the intent of #1393, building on the work completed in #1448.

Copy link
Contributor

@stilnat stilnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single change, change addressable build to default path, otherwise great work

@stilnat stilnat merged commit e9db54c into RE-SS3D:develop Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants