Skip to content

Issue 34 Web API Core Tests #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 74 commits into from
Jan 6, 2021
Merged

Issue 34 Web API Core Tests #43

merged 74 commits into from
Jan 6, 2021

Conversation

darnjo
Copy link
Member

@darnjo darnjo commented Nov 23, 2020

Adds Web API 1.0.2 Core Server automated testing, including Collections Support, to the Commander.
The Commander assumes Collection(Edm.EnumType) by default for multiple enumerations. Those using IsFlags="true" can pass -DuseCollections=false.

See #34 and README for more information.

TODO: still need to add all-in-one pretty reporting task for Web API before PR.

darnjo added 30 commits April 13, 2020 06:27
…ic). Metadata validation passes on generated file
darnjo and others added 13 commits October 23, 2020 12:40
…nored.json, and updated Vha, Usda, and Fha with VHA, USDA, and FHA
…ting mode, and metadata-report.json to output results to aggregation server
…ateCertificationReports_DD_1_7 task that takes -DpathToJsonResults from the cert task and creates a pretty report
…mander JAR tasks, as well as improved the all-in-one generateCertificationReport task
Updated some bad links in the README.
Added Bold items for consistency.
@darnjo darnjo requested review from EnFinlay and psftc November 24, 2020 01:15
Copy link
Collaborator

@EnFinlay EnFinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are far too many changes for me to give a thorough review of every single one. In general all the changes appear to be in line with decisions made in the Certification subgroup and the Transport workgroup.

One suggestion - could the odata-openapi folder be included as a git submodule?

@darnjo
Copy link
Member Author

darnjo commented Nov 24, 2020

Thanks for the review, Eric. This codebase is based on the Web API "Gold" automated testing code, which had previously been used to certify live servers. "Core" changed some of the existing tests and added a couple of new ones, but the underlying glue code is largely the same.

Good suggestion regarding making the odata-openapi project a submodule. I'll take care of that before merging. I'm also making an all-in-one testing and reporting task similar to the DD test code, which I'll provide instructions in the README for.

As far as what's included with these changes, I'll add a Release Notes section to the README since this is a significant release.

@EnFinlay
Copy link
Collaborator

Sounds good!

@darnjo darnjo linked an issue Dec 8, 2020 that may be closed by this pull request
6 tasks
@darnjo darnjo self-assigned this Jan 6, 2021
@darnjo darnjo added the inprogress Item is currently in progress label Jan 6, 2021
@darnjo darnjo added this to the Web API 1.0.2 Server Core milestone Jan 6, 2021
@darnjo
Copy link
Member Author

darnjo commented Jan 6, 2021

Merging. Will handle change to all() test in subsequent issue/PR.

@darnjo darnjo merged commit bf1c55c into master Jan 6, 2021
@darnjo darnjo deleted the issue-34-web-api-core-tests branch January 6, 2021 08:53
@darnjo darnjo removed the inprogress Item is currently in progress label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Web API Testing Code with Web API Core changes
2 participants