Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Unittests from UnitTest Repository into this repository on the fly #553

Merged
merged 13 commits into from
Apr 11, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Mar 24, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce?

Feature:
After moving the UnitTest module into a seperate repository, this caused some changes to get it working.

This Project now has a makefile (make test) which is running tests against modules included here.

  1. Downloads a makefile from the UnitTest Repostory
  2. Copy unittest specific libs and json files into the correct directory under /opt/fhem
  3. call make to run tests with options PERL_OPTS="-MDevel::Cover" (uses makefile from the UnitTest Repostory)
    a) This will again copy standard module files to the correct locations under /opt/fhem
    b) Restart fhem with special unittest configuration
    c) Runs every testfile which is located unter RFFHEM\UnitTest\tests and fulfills naming policy.
    d) stops fhem
  • What is the current behavior? (You can also link to an open issue here)

A copy of the unittest module resides static in our repository. Updates must be added manually.
The project makefile runs test only explicit specified testfiles.

  • What is the new behavior (if this is a feature change)?

The unittest module (with all needed files) is downloaded from the unittest repository before starting a test.
The project makefile in this project is minimalistic, because it triggers the makefile from the unittest repository which is more complex but independend from the specific tests.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No breaking change known, maybe modified testfiles must be matched to the new location

  • Other information:

This PR will use the makefile from the UnitTest repository for running tests. So the local makefile is reduced to a few lines.

sidey79 added 7 commits March 21, 2019 23:20
Moved test files to UnitTest/tests folder.

removed unused files
added target to copy libs
syntax fix
made correction to always run deploylocalLibs
Added project specific libs to test environment
@sidey79 sidey79 changed the base branch from master to dev-r34 March 26, 2019 21:01
sidey79 added 4 commits March 26, 2019 22:05
reverted changes for test
removed file from wrong location
UnitTest/tests/test_loadprotohash-ok.pm

removed files in wrong directory
run two make processes and ignore deleted files in cover report
@sidey79 sidey79 marked this pull request as ready for review March 27, 2019 21:06
HomeAutoUser
HomeAutoUser previously approved these changes Mar 27, 2019
@sidey79
Copy link
Contributor Author

sidey79 commented Mar 28, 2019

ich warte mit dem Merge auf #554 und #550 wegen Anpassungen

@coveralls
Copy link

coveralls commented Apr 5, 2019

Pull Request Test Coverage Report for Build 1410

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 1408: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@sidey79
Copy link
Contributor Author

sidey79 commented Apr 5, 2019

@HomeAutoUser
Sodele, der PR ist nun konfliktfrei

@HomeAutoUser
Copy link
Contributor

Wieder da in der OnlineWelt :D
Ich schaue es mir heute Daheim an.

@sidey79
Copy link
Contributor Author

sidey79 commented Apr 10, 2019

@HomeAutoUser
hattest Du schon Gelegenheit es mal anzusehen?

Copy link
Contributor

@HomeAutoUser HomeAutoUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mir fiehl erstmal nichts weiter auf

@sidey79 sidey79 merged commit 3646f57 into dev-r34 Apr 11, 2019
@sidey79 sidey79 deleted the dev-r34-unittest_submake branch April 11, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants