-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Unittests from UnitTest Repository into this repository on the fly #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Repository and run it
Moved test files to UnitTest/tests folder. removed unused files
reverted changes for test
removed file from wrong location
UnitTest/tests/test_loadprotohash-ok.pm removed files in wrong directory
run two make processes and ignore deleted files in cover report
HomeAutoUser
previously approved these changes
Mar 27, 2019
Pull Request Test Coverage Report for Build 1410
💛 - Coveralls |
@HomeAutoUser |
Wieder da in der OnlineWelt :D |
@HomeAutoUser |
HomeAutoUser
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mir fiehl erstmal nichts weiter auf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
After moving the UnitTest module into a seperate repository, this caused some changes to get it working.
This Project now has a makefile (make test) which is running tests against modules included here.
a) This will again copy standard module files to the correct locations under /opt/fhem
b) Restart fhem with special unittest configuration
c) Runs every testfile which is located unter RFFHEM\UnitTest\tests and fulfills naming policy.
d) stops fhem
A copy of the unittest module resides static in our repository. Updates must be added manually.
The project makefile runs test only explicit specified testfiles.
The unittest module (with all needed files) is downloaded from the unittest repository before starting a test.
The project makefile in this project is minimalistic, because it triggers the makefile from the unittest repository which is more complex but independend from the specific tests.
No breaking change known, maybe modified testfiles must be matched to the new location
This PR will use the makefile from the UnitTest repository for running tests. So the local makefile is reduced to a few lines.