gnrc_pktbuf_cmd: add od dependency with gnrc_pktbuf_static #17228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test does not use the module, it is merely used as a dependency for `gnrc_pktbuf_cmd`.
miri64
added
the
Type: enhancement
miri64
requested review from
cgundogan,
haukepetersen and
PeterKietzmann
as code owners
github-actions
bot
added
Area: network
miri64
changed the title
fjmolinas
reviewed
Nov 17, 2021
| @@ -8,7 +8,6 @@ USEMODULE += gnrc_pktbuf_cmd | |||
| USEMODULE += gnrc_udp | |||
| USEMODULE += gnrc_rpl | |||
| USEMODULE += auto_init_gnrc_rpl | |||
| USEMODULE += od | |||
There was a problem hiding this comment.
Do you mind removing it from all the other tests selecting gnrc_pktbuf_cmd that do not need to select od since they do not use it directly?
There was a problem hiding this comment.
Some of them include it for other reasons and this needs to be carefully checked. Can we do it as a follow-up?
benpicco
approved these changes
Jan 3, 2022
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The
pktbufshell command only prints something withgnrc_pktbuf_static, when theodmodule is also compiled in. Currently, it is up to the user to include that module, however, I don't think there is much sense behind that. This PR pulls inodwhengnrc_pktbuf_cmdandgnrc_pktbuf_staticare compiled in.Testing procedure
Revert the commit that adds the new dependency (d4f7f91 when this PR was opened). Flash
tests/gnrc_udpto a board of your choice, runmake termand typepktbuf. No output will be shown. If you then reintroduce the addition of the dependency and repeat the flashing,pktbufwill show a similar output (if not the same) as in master.Issues/PRs references
None