Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_pktbuf_cmd: add od dependency with gnrc_pktbuf_static #17228

Merged
merged 2 commits into from
Jan 17, 2022
Merged

gnrc_pktbuf_cmd: add od dependency with gnrc_pktbuf_static #17228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b7ea4
tests/gnrc_udp: remove od from used modules
miri64 Nov 17, 2021
d4f7f91
gnrc_pktbuf_cmd: add `od` dependency with `gnrc_pktbuf_static`
miri64 Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sys/net/gnrc/Makefile.dep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,12 @@ ifneq (,$(filter gnrc_pktbuf_%, $(USEMODULE)))
USEMODULE += gnrc_pktbuf # make MODULE_GNRC_PKTBUF macro available for all implementations
endif

ifneq (,$(filter gnrc_pktbuf_cmd,$(USEMODULE)))
ifneq (,$(filter gnrc_pktbuf_static,$(USEMODULE)))
USEMODULE += od
endif
endif

ifneq (,$(filter gnrc_netif_%,$(USEMODULE)))
USEMODULE += gnrc_netif
endif
Expand Down
1 change: 0 additions & 1 deletion tests/gnrc_udp/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ USEMODULE += gnrc_pktbuf_cmd
USEMODULE += gnrc_udp
USEMODULE += gnrc_rpl
USEMODULE += auto_init_gnrc_rpl
USEMODULE += od
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind removing it from all the other tests selecting gnrc_pktbuf_cmd that do not need to select od since they do not use it directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of them include it for other reasons and this needs to be carefully checked. Can we do it as a follow-up?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

USEMODULE += gnrc_icmpv6_echo
USEMODULE += shell
USEMODULE += shell_commands
Expand Down