Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: use ESP-IDF interrupt HAL for periph/uart #18274

Merged
merged 2 commits into from
Jul 15, 2022
Merged

cpu/esp32: use ESP-IDF interrupt HAL for periph/uart #18274

merged 2 commits into from
Jul 15, 2022

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jun 28, 2022 •
edited
Loading

Contribution description

This PR is a split-off from PR #17841 that:

  • provides the changes to use ESP-IDF interrupt HAL for periph/uart and
  • inverts the MCU_* conditionals so that they can be tested for ESP8266. In all other cases the MCU is any ESP32x SoC.

Testing procedure

  1. Green CI
  2. Compile and check any simple test app, for example: 
    BOARD=esp32-wroom-32 make -j8 -C tests/shell flash term

Issues/PRs references

Split-off from PR #17841
Prerequisite for PR #18280

@gschorcht
cpu/esp32: add uart to ESP-IDF interface API
81caeb1
@gschorcht
cpu/esp_common: port periph/uart to ESP-IDF uart API
4b2b004 
This commit changes periph/uart to use ESP-IDF API for ESP32x SoCs. Furthermore, the MCU_* conditionals are inverted so that they can be tested for ESP8266. In all other cases the MCU is any ESP32x SoC
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 28, 2022
@gschorcht gschorcht requested a review from benpicco June 28, 2022 14:36
@gschorcht gschorcht mentioned this pull request Jun 28, 2022
Merged
@gschorcht gschorcht changed the title cpu/esp32: use ESP-IDF interrupt HAL for UART cpu/esp32: use ESP-IDF interrupt HAL for periph/uart Jun 28, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 13, 2022
@benpicco benpicco merged commit 1e8f387 into RIOT-OS:master Jul 15, 2022
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging

@gschorcht gschorcht deleted the cpu/esp32/periph_hal_esp32_uart branch July 15, 2022 09:13
@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @benpicco @chrysn