Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: use ESP-IDF sleep API for periph/pm #18280

Merged
merged 1 commit into from
Jul 17, 2022
Merged

cpu/esp32: use ESP-IDF sleep API for periph/pm #18280

merged 1 commit into from
Jul 17, 2022

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jun 28, 2022 •
edited
Loading

Contribution description

This PR is a split-off from PR #17841 and provides the changes to use the ESP-IDF sleep API for periph/pm

This PR depends on PR #18274.

Testing procedure

Compile and test the hardware implementation with

USEMODULE='esp_i2c_hw esp_log_startup' BOARD=esp32-wroom-32 make -j8 -C tests/periph_pm flash term

Issues/PRs references

Split-off from PR #17841
Depends on PR #18274

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht requested a review from benpicco June 28, 2022 19:09
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first labels Jun 28, 2022
@gschorcht gschorcht mentioned this pull request Jul 13, 2022
Merged
@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_pm branch from 0701722 to e241826 Compare July 15, 2022 12:12
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Jul 15, 2022
benpicco
benpicco reviewed Jul 15, 2022
View reviewed changes
cpu/esp32/periph/pm.c Outdated Show resolved Hide resolved
benpicco
benpicco approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_pm branch from c1c0c38 to a74a19e Compare July 15, 2022 14:33
@benpicco benpicco merged commit 6ba048f into RIOT-OS:master Jul 17, 2022
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/esp32/periph_hal_esp32_pm branch July 17, 2022 15:20
@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @benpicco @chrysn