-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver/lsm6dsxx: Allow generic LSM6DSXX driver #20504
driver/lsm6dsxx: Allow generic LSM6DSXX driver #20504
Conversation
778af29
to
57e006d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this! 👍 Two questions below.
Can confirm this (still) works here with board revision B.
I guess this means we have to runtime check the whoami register and use those values for calculating the temp (and anything else that shows up). |
Also temperature offset of +-15 I don't understand |
Just to make sure there is no confusion: the driver currently supports two variants (LSM6DS33 and LSM6DSL). The new feather board rev. C uses neither of them. It uses the LSM6DS3TR-C. Although LSM6DSL and LSM6DS3TR-C seem very similar its probably still better to check against all datasheets ;)
I interpret it as "the temperature sensor will have pretty poor accuracy in terms of absolute temperature" i.e., a register value of 0 refers to something between 10 °C and 40 °C |
warning: Member LSM6DSL_REG_X_OFS_USR (macro definition) of file lsm6dsxx_internal.h is not documented. | ||
warning: Member LSM6DSL_REG_Y_OFS_USR (macro definition) of file lsm6dsxx_internal.h is not documented. | ||
warning: Member LSM6DSL_REG_Z_OFS_USR (macro definition) of file lsm6dsxx_internal.h is not documented. | ||
warning: Member LSM6DS33_REG_ORIENT_CFG_G (macro definition) of file lsm6dsxx_internal.h is not documented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way of telling doxygen that a define is only used internally? Something like @internal
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably but I don't know how... this is what we did for the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to just skip internal header files for the generated documentation? ala https://stackoverflow.com/questions/11025971/separate-internal-from-external-documentation-in-doxygen with @cond
or just skip those for the "missing documentation" check?
May I squash (seeing as the first commit won't work for our use case)? |
Go for it! |
8613bec
to
00724b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more minor things (you may squash directly).
00724b0
to
b98e5bd
Compare
ping @mguetschow all good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM, thanks! Also tested locally to (still) work on the rev. B board.
Thanks! Next will be adding it to saul I guess :) |
Contribution description
We noticed that the different variants of the
feather-nrf52840-sense
boards (B/C) have different LSM6DSXX variants. Instead of making 2 different boards, we would just allow the LSM6DSXX module to be used by itself and only the generic (so far all of them) functions can be used.This also allows automated tests to be run... with some fun surprises along the way.
Testing procedure
Run the following on both variants:
both should pass...
Issues/PRs references