Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/saml1x: avoid the use of bitfield in register calls #20710

Merged
merged 1 commit into from
May 30, 2024

Conversation

dylad
Copy link
Member

@dylad dylad commented May 29, 2024

Contribution description

This PR replaces all calls of foo->bar.bit.xyz = ABCD to foo->bar.reg &= ABCD for all SAML10/SAML11 MCUs
This should not have much impact on the code.

Testing procedure

A careful review.
CI should catch most of the failure but feel free to run some tests on hardware.

Issues/PRs references

see #20457

Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
@dylad dylad requested a review from benpicco May 29, 2024 15:48
@dylad dylad requested a review from kaspar030 as a code owner May 29, 2024 15:48
@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports labels May 29, 2024
@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 29, 2024
@riot-ci
Copy link

riot-ci commented May 29, 2024

Murdock results

✔️ PASSED

0ce8780 cpu/saml1x: avoid the use of bitfield

Success Failures Total Runtime
10142 0 10143 17m:23s

Artifacts

@maribu maribu added this pull request to the merge queue May 30, 2024
Merged via the queue into RIOT-OS:master with commit be4dd0e May 30, 2024
27 checks passed
@dylad
Copy link
Member Author

dylad commented May 30, 2024

Thanks !

@dylad dylad deleted the pr/cpu/saml1x/avoid_bitfields_reg branch May 30, 2024 11:52
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants