Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket_base: remove deprecated header files #3885

Merged
merged 1 commit into from
Sep 24, 2015

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Sep 17, 2015

Removes (hopefully) all very last remnants of the old network stack

Depends on #3646 (merged), #3876 (merged), #3878 (merged) and #3882 (merged).

@miri64 miri64 added Area: network Area: Networking Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Sep 17, 2015
@miri64 miri64 added this to the Release 2015.09 milestone Sep 17, 2015
@miri64 miri64 force-pushed the socket_base/clean/rm branch from 67a9e64 to 4549b32 Compare September 21, 2015 13:49
@miri64
Copy link
Member Author

miri64 commented Sep 21, 2015

Rebased to current master and dependencies.

@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 21, 2015
@miri64 miri64 force-pushed the socket_base/clean/rm branch from 4549b32 to 6a66762 Compare September 22, 2015 21:39
@miri64
Copy link
Member Author

miri64 commented Sep 22, 2015

Rebased to current dependencies and master.

ifneq (,$(filter nhdp,$(USEMODULE)))
USEMODULE += conn_udp
USEMODULE += vtimer
USEMODULE += oonf_common
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need, you state below that oonf_rfc5444 depends on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review changes to NHDP and OONF in #3876 and #3882. This PR just removes the files related to socket_base

@miri64 miri64 force-pushed the socket_base/clean/rm branch from 6a66762 to 00746c5 Compare September 23, 2015 13:00
@miri64
Copy link
Member Author

miri64 commented Sep 23, 2015

Fixed the merge conflict error, so that @haukepetersen is happy with the state of this PR :-)

@haukepetersen
Copy link
Contributor

looks better. Will give a second look once the dependency is merged and its rebased...

@miri64 miri64 force-pushed the socket_base/clean/rm branch from 00746c5 to d6605c4 Compare September 23, 2015 16:22
@miri64
Copy link
Member Author

miri64 commented Sep 23, 2015

Rebased to current master and #2772.

@miri64 miri64 force-pushed the socket_base/clean/rm branch from d6605c4 to dbd1f89 Compare September 24, 2015 12:37
@miri64
Copy link
Member Author

miri64 commented Sep 24, 2015

Rebased to current #2772

@miri64 miri64 force-pushed the socket_base/clean/rm branch from dbd1f89 to 8b2e4d5 Compare September 24, 2015 13:45
@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 24, 2015
@miri64
Copy link
Member Author

miri64 commented Sep 24, 2015

Rebased to current master

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 24, 2015
@miri64
Copy link
Member Author

miri64 commented Sep 24, 2015

(not waiting on another PR anymore)

@haukepetersen
Copy link
Contributor

ACK and go.

haukepetersen added a commit that referenced this pull request Sep 24, 2015
socket_base: remove deprecated header files
@haukepetersen haukepetersen merged commit 177dd5f into RIOT-OS:master Sep 24, 2015
@miri64 miri64 deleted the socket_base/clean/rm branch September 24, 2015 14:17
@miri64
Copy link
Member Author

miri64 commented Sep 24, 2015

Yay, last PR (for now) for RC merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants