Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Send Mail to Undeliverable Addresses #1404

Merged
merged 127 commits into from
Mar 13, 2024
Merged

Don't Send Mail to Undeliverable Addresses #1404

merged 127 commits into from
Mar 13, 2024

Conversation

eshryane
Copy link
Member

@eshryane eshryane commented Feb 26, 2024 •
edited
Loading

Functional Changes

  • Add One-click unsubscribe support to all outgoing Whois email messages
  • Detect undeliverable outgoing email messages, do not send any further messages to that address

Technical Changes

  • Add List-Unsubscribe and List-Unsubscribe-Post headers to all outgoing email messages

Known Issues

  • Delivery Status Notification delayed responses are not removed from the mailupdates table
  • Whois Update acknowledgements (replies) are not sent to an unsubscribed address.

MiguelAHM and others added 17 commits February 22, 2024 16:17
@MiguelAHM
feat: create bounce email logic for a single email mail service. Rema…
dfec012 
…ining: ITs, multiple email
@MiguelAHM
feat: refactor, move everything to commons
3e8e4d1
@MiguelAHM
feat: fix tests
5d344ee
@MiguelAHM
feat: use javasender impl instead a custom one
4bc689d
@MiguelAHM
feat: store already existing message id listener and event listener
dc12349
@MiguelAHM
feat: rename method
a8bd410
@MiguelAHM
feat: add TODO when we need to move the bouncing detector
0be44b0
@eshryane
Renamed "e_mail" column to "email" to be consistent with other tables
b84c720
@eshryane
Added TODOs
ef0bfd0
@eshryane
Renamed bounced_email_address to undeliverable_email to better de…
74f3bd6 
…scribe its function (i.e. a mail *message* will bounce, and the undeliverable email address will be stored in this table)
@eshryane
Renamed in_progress_mail to in_progress_message to distinguish ou…
8c4045d 
…tgoing mail message from email address ("mail" is ambiguous)
@eshryane
Fix comment syntax in SQL files
07e1ccd
@eshryane
Don't use camel casing for database column names
901e200
@eshryane
Fix SQL
c976f61
@MiguelAHM
feat: add new database call form repository for whois-internal endpoint
acab52c
@eshryane
Replace previous Mail integration test class with one that mocks the …
585bc70 
…mail sender
@MiguelAHM
feat: fix unit tests
d90bb0c
@eshryane eshryane marked this pull request as draft February 26, 2024 12:18
MiguelAHM and others added 11 commits March 11, 2024 09:37
@eshryane eshryane self-assigned this Mar 13, 2024
@eshryane
Add /api/ to db-web-ui unsubscribe URL
3ac83ff
@eshryane
Check base web URL ending (don't construct a URL with a double forwar…
35386d8 
…d slash as it'll produce a 400 bad Request "Ambiguous URI empty segment" from Jetty)/
@eshryane eshryane mentioned this pull request Mar 13, 2024
Merged
@eshryane
Copy link
Member Author

Integration tests passed

@eshryane eshryane merged commit 156c379 into master Mar 13, 2024
1 check passed
@eshryane eshryane deleted the DB-5195-avoid-bounced-emails branch March 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelAHM MiguelAHM MiguelAHM approved these changes

@maggarwal13 maggarwal13 Awaiting requested review from maggarwal13 maggarwal13 is a code owner

Assignees

@eshryane eshryane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshryane @MiguelAHM