Log warn when mail not sent #1407

MiguelAHM · 2024-03-13T10:46:29Z

Depends on #1404

…ining: ITs, multiple email

…scribe its function (i.e. a mail *message* will bounce, and the undeliverable email address will be stored in this table)

…tgoing mail message from email address ("mail" is ambiguous)

…mail sender

…velope reply and handle in MessageDequeue

…oing message, and we need to find it

…erBase

…or is unsubscribed

…d slash as it'll produce a 400 bad Request "Ambiguous URI empty segment" from Jetty)/

…n-mail-not-sent

whois-update/src/main/java/net/ripe/db/whois/update/handler/UpdateNotifier.java

whois-update/src/main/java/net/ripe/db/whois/update/domain/UpdateMessages.java

...e/src/main/java/net/ripe/db/whois/update/handler/validator/common/NotificationValidator.java

whois-api/src/test/java/net/ripe/db/whois/api/rest/WhoisRestServiceTestIntegration.java

whois-commons/src/main/java/net/ripe/db/whois/common/dao/EmailStatusDao.java

whois-update/src/main/java/net/ripe/db/whois/update/handler/UpdateNotifier.java

This reverts commit 359a3ca.

…hen" This reverts commit 03f4c81.

MiguelAHM · 2024-03-14T08:55:12Z

test ok
https://gitlab.ripe.net/swe-database-team/whois/-/pipelines/533832

MiguelAHM and others added 30 commits February 22, 2024 16:17

feat: create bounce email logic for a single email mail service. Rema…

dfec012

…ining: ITs, multiple email

feat: refactor, move everything to commons

3e8e4d1

feat: fix tests

5d344ee

feat: use javasender impl instead a custom one

4bc689d

feat: store already existing message id listener and event listener

dc12349

feat: rename method

a8bd410

feat: add TODO when we need to move the bouncing detector

0be44b0

Renamed "e_mail" column to "email" to be consistent with other tables

b84c720

Added TODOs

ef0bfd0

Renamed bounced_email_address to undeliverable_email to better de…

74f3bd6

…scribe its function (i.e. a mail *message* will bounce, and the undeliverable email address will be stored in this table)

Renamed in_progress_mail to in_progress_message to distinguish ou…

8c4045d

…tgoing mail message from email address ("mail" is ambiguous)

Fix comment syntax in SQL files

07e1ccd

Don't use camel casing for database column names

901e200

Fix SQL

c976f61

feat: add new database call form repository for whois-internal endpoint

acab52c

Replace previous Mail integration test class with one that mocks the …

585bc70

…mail sender

feat: fix unit tests

d90bb0c

Don't use a JavaMail Listener to detect send failures, instead set en…

88da56a

…velope reply and handle in MessageDequeue

Don't use a JavaMail Listener to detect send failures

2a0fe9c

Tests

ffaa669

Generate failure notification message and put it in the mail queue

e42d250

Added TODO

e841089

Added example emails for delayed delivery and permanent failure

a645234

The failure reply message-id has a different Message-Id than the outg…

ee5bd46

…oing message, and we need to find it

Updated tests

8a73494

Add Nullable

f770eb3

Add Nullable

5c991bc

Remember to enable DSN

ed8cd4a

feat: do not use bounced, use undeliverable for naming

0b9bef4

feat: rename table, createMessageId before sending, rollback MailSend…

daebe52

…erBase

eshryane and others added 5 commits March 12, 2024 20:27

Merge branch 'master' into DB-5195-avoid-bounced-emails

3567e57

Add /api/ to db-web-ui unsubscribe URL

3ac83ff

feat: add business rule for warn the user if mail is not deliverable …

ebc486c

…or is unsubscribed

Check base web URL ending (don't construct a URL with a double forwar…

35386d8

…d slash as it'll produce a 400 bad Request "Ambiguous URI empty segment" from Jetty)/

feat: use IN for getting all the results as one

be80627

MiguelAHM requested review from eshryane, fmurodov, isvonja and maggarwal13 as code owners March 13, 2024 10:46

MiguelAHM and others added 2 commits March 13, 2024 11:52

Merge branch 'DB-5195-avoid-bounced-emails' into DB-5227-log-warn-whe…

a6e8823

…n-mail-not-sent

Merge branch 'master' into DB-5227-log-warn-when-mail-not-sent

c22d25f