Remove Message If Bounce Detection Or Unsubscribe Fails #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelAHM
requested review from
eshryane,
fmurodov,
isvonja and
maggarwal13
as code owners
maggarwal13
reviewed
Mar 28, 2024
whois-api/src/main/java/net/ripe/db/whois/api/mail/dequeue/MessageDequeue.java
Outdated
Show resolved
Hide resolved
…part or textplain message and doesn't meet the requirements
* feat: little refactor in mailGatewaySmtp * feat: from can be different from whois-internal as well * feat: from should be always from mail.smtp
* feat: move rao rpki validator common code from whois internal to whois * feat: move code into common module, add component and service and return an error if optional property is empty * feat: return null and add nullable annotation * feat: put less roas * Allow MimeMessageHelper as parameter in MailGatewaySmtp (#1420) * feat: little refactor in mailGatewaySmtp * feat: from can be different from whois-internal as well * feat: from should be always from mail.smtp * feat: fix a TODO typo and IT should work even if roas are not specified
* feat: move dummifier class to correct module * feat: move roas.json to common
* Final-Recipient: RFC822 is case insensitive. * There may also be a space separator
* _check_valid_notification_file * refactor --------- Co-authored-by: Ed Shryane <eshryane@ripe.net>
* remove_unused_code * fix_tests
…e Same Email Address (#1417) * feat: remove message after error and catch DuplicateKeyException * feat: split the changes, just leave Catch in this PR * feat: catch the exception by email, no for all the emails. Turn the warn into debug * feat: put white space after try and before bracket * feat: just loop once * Added test to make sure the message doesn't get stuck * Fix test (rs.next() behaves the same if there is a result row or not) --------- Co-authored-by: Ed Shryane <eshryane@ripe.net>
MiguelAHM
changed the title
MiguelAHM
commented
Apr 16, 2024
whois-api/src/main/java/net/ripe/db/whois/api/mail/dequeue/MessageDequeue.java
Outdated
Show resolved
Hide resolved
MiguelAHM
commented
Apr 16, 2024
whois-api/src/main/java/net/ripe/db/whois/api/mail/dequeue/MessageDequeue.java
Outdated
Show resolved
Hide resolved
eshryane
approved these changes
Apr 16, 2024
… message fails, log as error when there is some unexpected error in the message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.