Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored inetnum status validation #1429

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Refactored inetnum status validation #1429

merged 2 commits into from
Apr 9, 2024

Conversation

maggarwal13
Copy link
Contributor

@maggarwal13 maggarwal13 commented Apr 9, 2024 •
edited by eshryane
Loading

  • An ALLOCATED PA inetnum requires to be mnt-by an RS maintainer
  • Removed unused code (an allocation mntner is only needed for inet6num, not inetnum)

@MiguelAHM
Copy link
Contributor

In this PR we are doing more than just removing code, right? Do we need to update the tittle?

@maggarwal13 maggarwal13 merged commit d0dbb9d into master Apr 9, 2024
1 check passed
@maggarwal13 maggarwal13 deleted the refactor_inetnum_validator branch April 9, 2024 12:14
@eshryane eshryane changed the title remove_unused_code Refactored inetnum status validation Apr 9, 2024
@eshryane
Copy link
Member

eshryane commented Apr 9, 2024

In this PR we are doing more than just removing code, right? Do we need to update the tittle?

I reviewed the changes with @maggarwal13, updated the title and description.

@MiguelAHM
Copy link
Contributor

In this PR we are doing more than just removing code, right? Do we need to update the tittle?

I reviewed the changes with @maggarwal13, updated the title and description.

Thanks, much clear now

MiguelAHM pushed a commit that referenced this pull request Apr 10, 2024
@maggarwal13 @MiguelAHM
remove_unused_code (#1429)
91dab3f 
* remove_unused_code

* fix_tests
MiguelAHM pushed a commit that referenced this pull request Apr 10, 2024
@maggarwal13 @MiguelAHM
remove_unused_code (#1429)
ce0a9ee 
* remove_unused_code

* fix_tests
@maggarwal13 maggarwal13 mentioned this pull request Apr 10, 2024
Merged
MiguelAHM added a commit that referenced this pull request Apr 16, 2024
@MiguelAHM @eshryane @maggarwal13
Remove Message If Bounce Detection Or Unsubscribe Fails (#1418)
775c529 
* feat: remove the email if bounce message failed

* feat: refactor to just return and delete the message when it is multipart or textplain message and doesn't meet the requirements

* Allow MimeMessageHelper as parameter in MailGatewaySmtp (#1420)

* feat: little refactor in mailGatewaySmtp

* feat: from can be different from whois-internal as well

* feat: from should be always from mail.smtp

* Roa Rpki Validator From Internal (#1419)

* feat: move rao rpki validator common code from whois internal to whois

* feat: move code into common module, add component and service and return an error if optional property is empty

* feat: return null and add nullable annotation

* feat: put less roas

* Allow MimeMessageHelper as parameter in MailGatewaySmtp (#1420)

* feat: little refactor in mailGatewaySmtp

* feat: from can be different from whois-internal as well

* feat: from should be always from mail.smtp

* feat: fix a TODO typo and IT should work even if roas are not specified

* Move RPKI Validator Dummifier to Correct Module (#1421)

* feat: move dummifier class to correct module

* feat: move roas.json to common

* Final-Recipient: RFC822 is case insensitive (#1423)

* Final-Recipient: RFC822 is case insensitive.

* There may also be a space separator

* feat: move all message logic from whois-internal to whois (#1424)

* feat: runtime exception fix when using this module (#1425)

* feat: do no return error if roas are not loaded (#1426)

* Return 404 on invalid NRTMv4 notification file path (#1422)

* _check_valid_notification_file

* refactor

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* feat: fix logger issue (#1427)

* remove_unused_code (#1429)

* remove_unused_code

* fix_tests

* Revert changes to thread configuration in tests (#1415)

* Handle Multiple Delivery Status Notification Failure Responses for the Same Email Address (#1417)

* feat: remove message after error and catch DuplicateKeyException

* feat: split the changes, just leave Catch in this PR

* feat: catch the exception by email, no for all the emails. Turn the warn into debug

* feat: put white space after try and before bracket

* feat: just loop once

* Added test to make sure the message doesn't get stuck

* Fix test (rs.next() behaves the same if there is a result row or not)

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* feat: remove disabled and catch illegalStateException

* feat: remove unused imports and add serialId to the exception

* feat: return null in case unsubscription parsing do not succed

* feat: fix tests

* feat: log as info instead error when bouce detection or unsubscribing message fails, log as error when there is some unexpected error in the message

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>
Co-authored-by: maggarwal13 <50230916+maggarwal13@users.noreply.github.com>
MiguelAHM added a commit that referenced this pull request Apr 16, 2024
@MiguelAHM @maggarwal13
@eshryane @fmurodov
Route ROA checker (#1416)
565ce1f 
* feat: create new warning for roas check and test for legacy

* feat: add test for REST API calls and little refactor to specify rest messages

* feat: fix ITs

* feat: add more tests

* feat: create the validator

* feat: fix compile error due to previous code

* feat: renaming and deleting white spaces

* feat: fix tests according to last changes

* feat: remove already migrated classes

* feat: change generator by validator

* feat: fix compilation errors

* feat: increase testperformance to 3s

* feat: put timeout back to 2s and fix compilation issue in whoisFixture

* feat: fix compilation issues

* feat: fix ITs

* feat: refactor messages and PR comments

* feat: fix ITs

* feat: refactor

* feat: rename

* feat: rename

* Return 404 on invalid NRTMv4 notification file path (#1422)

* _check_valid_notification_file

* refactor

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* feat: fix logger issue (#1427)

* remove_unused_code (#1429)

* remove_unused_code

* fix_tests

* Revert changes to thread configuration in tests (#1415)

* Handle Multiple Delivery Status Notification Failure Responses for the Same Email Address (#1417)

* feat: remove message after error and catch DuplicateKeyException

* feat: split the changes, just leave Catch in this PR

* feat: catch the exception by email, no for all the emails. Turn the warn into debug

* feat: put white space after try and before bracket

* feat: just loop once

* Added test to make sure the message doesn't get stuck

* Fix test (rs.next() behaves the same if there is a result row or not)

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* Fix tests (#1433)

* fix tests

* fix tests

* reduce mariadb innodb memory usage to 1GB (#1439)

* Set memory limit for test elasticsearch instance (#1436)

* Set memory limit for test elasticsearch instance

* Move ES memlimit to ENV variable

* Reduce elasticsearch memory limit

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* feat: renaming, revert ErrorMessages changes, change the query flag, remove @service

* feat: use a queryParameter instead of queryFlag

* feat: add stopwatch to monitor the performance of RPKI service

* feat: add missing return

* feat: rpki service should be a @service and RpkiRoaChecker a component because performance issues, pulling all roas each call

* feat: remove unused imports

* feat: ignore roa update if there is an error with the call

* feat: align errormessages name with objectmessages, same format

* feat: fix lookup case, when roa-checker is not a parameter

* feat: pass the type as parameter for the message and create two test for route6

* feat: return different messages per use case; origin fail, prefix length or both

* feat: change warning message

---------

Co-authored-by: maggarwal13 <50230916+maggarwal13@users.noreply.github.com>
Co-authored-by: Ed Shryane <eshryane@ripe.net>
Co-authored-by: Firdavs Murodov <fmurodov@ripe.net>
MiguelAHM added a commit that referenced this pull request Apr 18, 2024
@MiguelAHM @maggarwal13
@eshryane @fmurodov
Schedule ROA load each 15 minutes (#1444)
dc6e931 
* feat: create new warning for roas check and test for legacy

* feat: add test for REST API calls and little refactor to specify rest messages

* feat: fix ITs

* feat: add more tests

* feat: create the validator

* feat: fix compile error due to previous code

* feat: renaming and deleting white spaces

* feat: fix tests according to last changes

* feat: remove already migrated classes

* feat: change generator by validator

* feat: fix compilation errors

* feat: increase testperformance to 3s

* feat: put timeout back to 2s and fix compilation issue in whoisFixture

* feat: fix compilation issues

* feat: fix ITs

* feat: refactor messages and PR comments

* feat: fix ITs

* feat: refactor

* feat: rename

* feat: rename

* Return 404 on invalid NRTMv4 notification file path (#1422)

* _check_valid_notification_file

* refactor

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* feat: fix logger issue (#1427)

* remove_unused_code (#1429)

* remove_unused_code

* fix_tests

* Revert changes to thread configuration in tests (#1415)

* Handle Multiple Delivery Status Notification Failure Responses for the Same Email Address (#1417)

* feat: remove message after error and catch DuplicateKeyException

* feat: split the changes, just leave Catch in this PR

* feat: catch the exception by email, no for all the emails. Turn the warn into debug

* feat: put white space after try and before bracket

* feat: just loop once

* Added test to make sure the message doesn't get stuck

* Fix test (rs.next() behaves the same if there is a result row or not)

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* Fix tests (#1433)

* fix tests

* fix tests

* reduce mariadb innodb memory usage to 1GB (#1439)

* Set memory limit for test elasticsearch instance (#1436)

* Set memory limit for test elasticsearch instance

* Move ES memlimit to ENV variable

* Reduce elasticsearch memory limit

---------

Co-authored-by: Ed Shryane <eshryane@ripe.net>

* feat: renaming, revert ErrorMessages changes, change the query flag, remove @service

* feat: use a queryParameter instead of queryFlag

* feat: add stopwatch to monitor the performance of RPKI service

* feat: add missing return

* feat: rpki service should be a @service and RpkiRoaChecker a component because performance issues, pulling all roas each call

* feat: schedule roas

* feat: remove blank lines

* use SynchonizedIntervalMap to avoid concurrent problems

* feat: remove unused import

* feat: fix cron expresion

* feat: intantiate new interval instead using clean

* feat: fix each seconds issue

* feat: use nestedIntervalMap instead async map

* feat: remove initial inizialisation

* feat: change message error and refactor

* feat: rename

* feat: avoid returning a pair

---------

Co-authored-by: maggarwal13 <50230916+maggarwal13@users.noreply.github.com>
Co-authored-by: Ed Shryane <eshryane@ripe.net>
Co-authored-by: Firdavs Murodov <fmurodov@ripe.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshryane eshryane eshryane approved these changes

@fmurodov fmurodov Awaiting requested review from fmurodov fmurodov is a code owner

@isvonja isvonja Awaiting requested review from isvonja isvonja is a code owner

@MiguelAHM MiguelAHM Awaiting requested review from MiguelAHM MiguelAHM is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maggarwal13 @MiguelAHM @eshryane