[HIPIFY][MIOpen][feature] `cuDNN` -> `MIOpen` transformations #584

emankov · 2022-07-01T13:44:31Z

MIopen lives here: https://github.com/ROCmSoftwarePlatform/MIOpen, it is alive and synced with ROCm HIP releases
First implement under an option, then switch on by default by switching cuDNN -> hipDNN off (obsolete)
Porting doc: https://github.com/ROCmSoftwarePlatform/MIOpen/blob/develop/doc/src/MIOpen_Porting_Guide.md

The text was updated successfully, but these errors were encountered:

+ Introduced the `API_DNN` as yet another API to hipify under the `--roc` option + Introduced a new synthetic test `cudnn2miopen.cu` + Added just a few cudnn2miopen mappings [ToDo] + Add the needed changes in the `hipify-perl` script generation + Start to generate yet another CUDA2HIP Markdown doc regarding cuDNN support in MIOpen + Decide what to do with the still being generated but not being published `CUDNN_API_supported_by_HIP.md` for cuDNN support in the obsolete hipDNN

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 1

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly + MIOpen has its own types, equal to HIP ones but without any connection (like redefines, for instance): + Example: cudaStream_t / hipStream_t / miopenAcceleratorQueue_t + [Solution] Started to use the "roc" mapping for Runtime APIs as well, which is used only under the `--roc` option [ToDo] + Form the above solution as a standalone function instead of an ad-hock workaround + Add the needed changes in the `hipify-perl` script generation + Start to generate yet another CUDA2HIP Markdown doc regarding cuDNN support in MIOpen + Decide what to do with the still being generated but not being published `CUDNN_API_supported_by_HIP.md` for cuDNN support in the obsolete hipDNN

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 2

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 3

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly + Fixed typos

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 4

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 5

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 6

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly [ToDo] + [feature] Arguments swap + [feature] Additional argument (const value, firstly)

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 7

+ [refactor] Introduced `ArgCastStruct` with additional fields `isToRoc` and `isToMIOpen` (both are `false` by default) for the correct argument casting in `roc*` and `miopen*` functions + Removed the penultimate (5th) arg `cudnnConvolutionFwdAlgo_t algo` from the `miopenConvolutionForwardGetWorkSpaceSize` function call after hipification of `cudnnGetConvolutionForwardWorkspaceSize` due to the absence of that argument in `miopenConvolutionForwardGetWorkSpaceSize`; no warning is emitted + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen][refactor] cuDNN -> MIOpen - Part 8

+ Continued supporting hipification to MIOpen based on `miopen.h`: `cudnnConvolutionBackwardBias` -> `miopenConvolutionBackwardBias` `cudnnGetConvolutionBackwardDataWorkspaceSize` -> `miopenConvolutionBackwardDataGetWorkSpaceSize` (TODO: swap 2 and 3 arguments) `cudnnConvolutionBackwardData` -> `miopenConvolutionBackwardData` (TODO: swap correctly all args, starting from 3rd) `cudnnCreatePoolingDescriptor` -> `miopenCreatePoolingDescriptor` `cudnnConvolutionBwdDataAlgoPerf_t` && `cudnnConvolutionFwdAlgoPerf_t` -> `miopenConvAlgoPerf_t` + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 9

…Part 10 + Add a new function call transformation type "additional const by value arg": the arg is added at ArgNum (starting from 0), if ArgNum >= `ArgNumCount` the arg is added at the end as the last function arg + Added a const argument `true` for `bool exhaustiveSearch` as the last argument in the `miopenFindConvolutionForwardAlgorithm` function calls + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][#822][DNN][MIOpen][feature] cuDNN -> MIOpen - Part 10

…ling functions + Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly + [IMP] `cudnnPoolingForward` and `cudnnPoolingBackward` do not have a correspondence to `miopenPoolingForward` and `miopenPoolingBackward` - to discuss with the team

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 11 - cuDNN Pooling functions

… functions + Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly + [IMP] `cudnnLRNCrossChannelForward` and `cudnnLRNCrossChannelBackward` do not have a correspondence to `miopenLRNForward` and `miopenLRNBackward` - to discuss with the team [ToDo] + [feature] Add a new type of transformation with declaring a var before the function call to add that var reference as an arg to the below function call + Add a referrence to miopenLRNMode_t as a 2nd arg for `miopenGetLRNDescriptor` function call

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 12 - cuDNN LRN functions

…ch Normalization functions + Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 13 - cuDNN Batch Normalization functions

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 16 - cuDNN RNN functions - partially

… functions - partially + Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 17 - cuDNN RNN functions - partially

… Loss functions + Finished with RNN functions + Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly [ToDo] + [ROCm#837] for miopenGetRNNDescriptor_V2, miopenSetRNNDescriptor_V2, miopenGetCTCLossDescriptor, and miopenSetCTCLossDescriptor

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 18 - cuDNN CTC Loss functions

…pout functions + Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly [ToDo] + [ROCm#837] for miopenGetDropoutDescriptor, miopenSetDropoutDescriptor, miopenRestoreDropoutDescriptor, miopenDropoutForward, and miopenDropoutBackward

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 19 - cuDNN Dropout functions

…uce Tensor functions + Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 20 - cuDNN Reduce Tensor functions

…direct translation from `cuDNN` to `MIOpen` - Part 1 + `cudnnTensorFormat_t` -> `miopenTensorLayout_t` + `cudnnBackendDescriptorType_t` -> `miopenBackendDescriptorType_t` + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation + [ToDo] `MIOpen` API versioning

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 1

…direct translation from `cuDNN` to `MIOpen` - Part 2 + `cudnnBackendAttributeType_t` -> `miopenBackendAttributeType_t` + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation + [ToDo] `MIOpen` API versioning

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 2

…direct translation from `cuDNN` to `MIOpen` - Part 3 + `cudnnBackendAttributeName_t` -> `miopenBackendAttributeName_t` - partial + Updated the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation + [ToDo] `synthetic tests

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 3

…direct translation from `cuDNN` to `MIOpen` - Part 4 + `cudnnBackendAttributeName_t` -> `miopenBackendAttributeName_t` - continuation + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 4

…direct translation from `cuDNN` to `MIOpen` - Part 5 + `cudnnBackendAttributeName_t` -> `miopenBackendAttributeName_t` - continuation + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 5

…direct translation from `cuDNN` to `MIOpen` - Part 6 + `cudnnBackendAttributeName_t` -> `miopenBackendAttributeName_t` - continuation + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 6

…direct translation from `cuDNN` to `MIOpen` - Part 7 + `cudnnBackendAttributeName_t` -> `miopenBackendAttributeName_t` - final + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 7

…direct translation from `cuDNN` to `MIOpen` - Part 8 + Added the missing `cudnnCTCGradMode_t` appeared in cuDNN 9.0.0 + Fixed: `cudnnReduceTensorOp_t` deprecated in cuDNN 9.0.0 was undeprecated in cuDNN 9.1.0 + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 8

…direct translation from `cuDNN` to `MIOpen` - Part 9 + `cudnnConvolutionMode_t` -> `miopenConvolutionMode_t` + `cudnnPointwiseMode_t` -> `miopenPointwiseMode_t` + `cudnnBackendDescriptor_t` -> `miopenBackendDescriptor_t` + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 9

…direct translation from `cuDNN` to `MIOpen` - Part 10 + `cudnnBackendHeurMode_t` -> `miopenBackendHeurMode_t` + `cudnnRngDistribution_t` -> `miopenRngDistribution_t` + Backend functions, except `miopenBackendInitialize` due to to ф signature difference from `cudnnBackendInitialize` + Updated synthetic tests, the regenerated `hipify-perl`, and `DNN` `CUDA2HIP` documentation

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 10

emankov added feature Feature request or implementation MIOpen labels Jul 1, 2022

emankov self-assigned this Jul 1, 2022

emankov added a commit that referenced this issue Nov 1, 2022

Merge pull request #680 from emankov/HIPIFY

1483c51

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 1

emankov added a commit that referenced this issue Nov 10, 2022

Merge pull request #689 from emankov/HIPIFY

2fd116b

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 2

emankov added a commit to emankov/HIPIFY that referenced this issue Nov 11, 2022

* [HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 3

47b30c0

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

emankov added a commit that referenced this issue Nov 12, 2022

Merge pull request #691 from emankov/HIPIFY

8ff3593

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 3

emankov added a commit to emankov/HIPIFY that referenced this issue Nov 15, 2022

[HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 4

896f04e

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly + Fixed typos

emankov added a commit that referenced this issue Nov 16, 2022

Merge pull request #694 from emankov/HIPIFY

87678c0

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 4

emankov added a commit to emankov/HIPIFY that referenced this issue Nov 20, 2022

[HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 5

efbac47

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

emankov added a commit that referenced this issue Nov 20, 2022

Merge pull request #697 from emankov/HIPIFY

a92fecf

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 5

emankov added a commit to emankov/HIPIFY that referenced this issue Nov 23, 2022

[HIPIFY][ROCm#584][DNN][MIOpen] cuDNN -> MIOpen - Part 6

65c84fd

+ Continued supporting hipification to MIOpen based on `miopen.h` + Updated the synthetic test `cudnn2miopen.cu` accordingly

emankov added a commit that referenced this issue Nov 23, 2022

Merge pull request #698 from emankov/HIPIFY

bdcc35c

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 6

emankov added a commit that referenced this issue Mar 31, 2023

Merge pull request #820 from emankov/HIPIFY

05edfbe

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 7

emankov added the DNN DNN-related label Mar 31, 2023

emankov added a commit that referenced this issue Apr 1, 2023

Merge pull request #821 from emankov/HIPIFY

31d10de

[HIPIFY][#584][DNN][MIOpen][refactor] cuDNN -> MIOpen - Part 8

emankov added a commit that referenced this issue Apr 1, 2023

Merge pull request #823 from emankov/HIPIFY

82edd28

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 9

emankov added a commit that referenced this issue Apr 2, 2023

Merge pull request #824 from emankov/HIPIFY

63446cf

[HIPIFY][#584][#822][DNN][MIOpen][feature] cuDNN -> MIOpen - Part 10

emankov added a commit that referenced this issue Apr 3, 2023

Merge pull request #825 from emankov/HIPIFY

e955d9c

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 11 - cuDNN Pooling functions

emankov added a commit that referenced this issue Apr 4, 2023

Merge pull request #826 from emankov/HIPIFY

9681409

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 12 - cuDNN LRN functions

emankov added a commit that referenced this issue Apr 4, 2023

Merge pull request #827 from emankov/HIPIFY

05c29aa

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 13 - cuDNN Batch Normalization functions

emankov added a commit that referenced this issue Apr 13, 2023

Merge pull request #838 from emankov/HIPIFY

7f24af2

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 16 - cuDNN RNN functions - partially

emankov added a commit that referenced this issue Apr 15, 2023

Merge pull request #840 from emankov/HIPIFY

f5819d9

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 17 - cuDNN RNN functions - partially

emankov added a commit that referenced this issue Apr 16, 2023

Merge pull request #841 from emankov/HIPIFY

c33bb26

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 18 - cuDNN CTC Loss functions

emankov added a commit that referenced this issue Apr 17, 2023

Merge pull request #842 from emankov/HIPIFY

ab42572

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 19 - cuDNN Dropout functions

emankov added a commit that referenced this issue Apr 18, 2023

Merge pull request #843 from emankov/HIPIFY

d38350e

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 20 - cuDNN Reduce Tensor functions

emankov added the partial Partial fix or implementation label Sep 28, 2023

emankov added a commit that referenced this issue Aug 23, 2024

Merge pull request #1629 from emankov/HIPIFY

850173b

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 1

emankov added a commit that referenced this issue Aug 26, 2024

Merge pull request #1631 from emankov/HIPIFY

2b6db7c

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 2

emankov added a commit that referenced this issue Sep 3, 2024

Merge pull request #1636 from emankov/HIPIFY

96ad693

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 3

emankov added a commit that referenced this issue Sep 4, 2024

Merge pull request #1638 from emankov/HIPIFY

7facf88

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 4

emankov added a commit that referenced this issue Sep 5, 2024

Merge pull request #1640 from emankov/HIPIFY

635ad63

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 5

emankov added a commit that referenced this issue Sep 6, 2024

Merge pull request #1641 from emankov/HIPIFY

14ecf7a

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 6

emankov added a commit that referenced this issue Sep 9, 2024

Merge pull request #1644 from emankov/HIPIFY

1a287bd

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 7

emankov added a commit that referenced this issue Sep 12, 2024

Merge pull request #1649 from emankov/HIPIFY

36743fd

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 8

emankov added a commit that referenced this issue Sep 17, 2024

Merge pull request #1653 from emankov/HIPIFY

887096b

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 9

emankov added a commit that referenced this issue Sep 19, 2024

Merge pull request #1657 from emankov/HIPIFY

c0a89cd

[HIPIFY][#584][#1624][MIOpen] Support for backend `graphAPI` direct translation from `cuDNN` to `MIOpen` - Part 10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HIPIFY][MIOpen][feature] `cuDNN` -> `MIOpen` transformations #584

[HIPIFY][MIOpen][feature] `cuDNN` -> `MIOpen` transformations #584

emankov commented Jul 1, 2022 •

edited

Loading

[HIPIFY][MIOpen][feature] cuDNN -> MIOpen transformations #584

[HIPIFY][MIOpen][feature] cuDNN -> MIOpen transformations #584

Comments

emankov commented Jul 1, 2022 • edited Loading

[HIPIFY][MIOpen][feature] `cuDNN` -> `MIOpen` transformations #584

[HIPIFY][MIOpen][feature] `cuDNN` -> `MIOpen` transformations #584

emankov commented Jul 1, 2022 •

edited

Loading