Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY][feature] Add a new function call transformation type "additional const by value arg" #822

Closed
emankov opened this issue Apr 1, 2023 · 1 comment
Closed

[HIPIFY][feature] Add a new function call transformation type "additional const by value arg" #822

emankov opened this issue Apr 1, 2023 · 1 comment
Assignees
@emankov
Labels
feature Feature request or implementation

Comments

@emankov
Copy link
Collaborator

emankov commented Apr 1, 2023

Use cudnnFindConvolutionForwardAlgorithmEx -> miopenFindConvolutionForwardAlgorithm, where an additional bool arg is to be added at the end as a const true, as a case study.
@emankov emankov added the feature Feature request or implementation label Apr 1, 2023
@emankov emankov self-assigned this Apr 1, 2023
@emankov emankov changed the title [HIPIFY][feature] Add a new function call transformation "additional const by value arg" [HIPIFY][feature] Add a new function call transformation type "additional const by value arg" Apr 1, 2023
emankov added a commit to emankov/HIPIFY that referenced this issue Apr 2, 2023
@emankov
[HIPIFY][ROCm#584][ROCm#822][DNN][MIOpen][feature] cuDNN -> MIOpen - …
e9ee90f 
…Part 10

+ Add a new function call transformation type "additional const by value arg":
  the arg is added at ArgNum (starting from 0), if ArgNum >= `ArgNumCount` the arg is added at the end as the last function arg
+ Added a const argument `true` for `bool exhaustiveSearch` as the last argument in the `miopenFindConvolutionForwardAlgorithm` function calls
+ Updated the synthetic test `cudnn2miopen.cu` accordingly
emankov added a commit that referenced this issue Apr 2, 2023
@emankov
Merge pull request #824 from emankov/HIPIFY
63446cf 
[HIPIFY][#584][#822][DNN][MIOpen][feature] cuDNN -> MIOpen - Part 10
@emankov
Copy link
Collaborator Author

emankov commented Apr 2, 2023

Implemented by #824

@emankov emankov closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emankov emankov

Labels
feature Feature request or implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emankov