[CMake] Autodetect HSA_AMDGPU_GPU_TARGET #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding the HSA_AMDGPU_GPU_TARGET at compile time, autodetect it at runtime from the KFD topology. Change-Id: I00af68084869ab4d439e70cf8816c1c8868f224d
|
|
||
| if (NOT (HSA_AMDGPU_GPU_TARGET STREQUAL "kaveri" OR | ||
| HSA_AMDGPU_GPU_TARGET STREQUAL "carrizo" OR | ||
| HSA_AMDGPU_GPU_TARGET STREQUAL "fiji")) | ||
| HSA_AMDGPU_GPU_TARGET STREQUAL "fiji" OR | ||
| HSA_AMDGPU_GPU_TARGET STREQUAL "")) |
There was a problem hiding this comment.
I'm thinking instead of having an empty string to enable auto detection, how about using "auto"
|
@arodrigx7 Besides address comment from @scchan to replace empty string to "auto", could you also modify this pull request so it goes to "develop" branch? Starting from roc-1.0 we'd like to change branching strategy so master branch only carries release-ready commits. All latest development commits go into "develop" branch. |
|
No problem, I'll update the pull request tomorrow. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the HSA_AMDGPU_GPU_TARGET at compile time,
autodetect it at runtime from the KFD topology.
Change-Id: I00af68084869ab4d439e70cf8816c1c8868f224d