Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Autodetect HSA_AMDGPU_GPU_TARGET #35

Closed
wants to merge 1 commit into from
Closed

[CMake] Autodetect HSA_AMDGPU_GPU_TARGET #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,11 +276,12 @@ if (HSA_USE_AMDGPU_BACKEND)
endif (NOT AMDPHDRS)
endif ()

set(HSA_AMDGPU_GPU_TARGET "kaveri" CACHE STRING "Target GPU device (kaveri,carrizo,fiji)")
set(HSA_AMDGPU_GPU_TARGET "" CACHE STRING "Target GPU device (kaveri,carrizo,fiji)")

if (NOT (HSA_AMDGPU_GPU_TARGET STREQUAL "kaveri" OR
HSA_AMDGPU_GPU_TARGET STREQUAL "carrizo" OR
HSA_AMDGPU_GPU_TARGET STREQUAL "fiji"))
HSA_AMDGPU_GPU_TARGET STREQUAL "fiji" OR
HSA_AMDGPU_GPU_TARGET STREQUAL ""))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking instead of having an empty string to enable auto detection, how about using "auto"

MESSAGE(FATAL_ERROR "${HSA_AMDGPU_GPU_TARGET} is not a valid GPU")
endif()

Expand Down
51 changes: 48 additions & 3 deletions lib/clamp-hsatools.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,58 @@ if [ $KMDUMPLLVM == "1" ]; then
cp $1.linked.bc ./dump.linked.bc
fi

TOPOLOGY_SYSFS_DIR=/sys/devices/virtual/kfd/kfd/topology/nodes

# Prints GPU name for a given Device ID
# param - Device ID.
deviceIdToGpuName() {
local deviceId=$1; shift;
local platformName=""
case $deviceId in
1304 | 1305 | 1306 | 1307 | 1309 | 130a | 130b | 130c | 130d | 130e | 130f | \
1310 | 1311 | 1312 | 1313 | 1315 | 1316 | 1317 | 1318 | 131b | 131c | 131d )
platformName="kaveri" ;;
9874 | 9875 | 9876 | 9877 )
platformName="carrizo" ;;
7300 )
platformName="fiji" ;;
* )
echo "Warning: failed to autodetect target, defaulting to fiji"
platformName="fiji" ;;
esac
echo "$platformName"
}

# Prints GPU Name for the given Node ID
# param - Node Path
getNodeName() {
local nodePath=$1; shift;
local gpuIdInDec=$(cat $nodePath/properties | grep device_id | awk '{print $2}')
printf -v gpuIdInHex "%x" "$gpuIdInDec"
local gpuName=$(deviceIdToGpuName $gpuIdInHex)
echo "$gpuName"
}

# Prints the name of the first HSA node with a GPU associated with it
getDefaultHsaNodeName() {
for i in $(find $TOPOLOGY_SYSFS_DIR -maxdepth 1 -mindepth 1 -type d); do
local simdcount=$(cat $i/properties | grep simd_count | awk '{print $2}')
if [ $simdcount != 0 ]; then
echo "$(getNodeName $i)"
return
fi
done
}

HSA_AMDGPU_GPU_TARGET=@HSA_AMDGPU_GPU_TARGET@
HSA_AMDGPU_GPU_TARGET="${HSA_AMDGPU_GPU_TARGET:-$(getDefaultHsaNodeName)}"

# Optimization notes:
# -disable-simplify-libcalls: prevents transforming loops into library calls such as memset, memcopy on GPU

if [ $KM_USE_AMDGPU ]; then
# KMOPTOPT can be used to pass last-minute options to opt in LC backend
$HLC_OPT $KMOPTOPT -O3 -mtriple amdgcn--amdhsa -mcpu=@HSA_AMDGPU_GPU_TARGET@ -disable-simplify-libcalls -verify $1.linked.bc -o $1.opt.bc
$HLC_OPT $KMOPTOPT -O3 -mtriple amdgcn--amdhsa -mcpu=$HSA_AMDGPU_GPU_TARGET -disable-simplify-libcalls -verify $1.linked.bc -o $1.opt.bc
else
$HLC_OPT -O3 -disable-simplify-libcalls -verify $1.linked.bc -o $1.opt.bc
fi
Expand All @@ -93,9 +138,9 @@ if [ $KMDUMPLLVM == "1" ]; then
fi

if [ $KM_USE_AMDGPU ]; then
$HLC_LLC -O2 -mtriple amdgcn--amdhsa -mcpu=@HSA_AMDGPU_GPU_TARGET@ -filetype=obj -o $1.hsail $1.opt.bc
$HLC_LLC -O2 -mtriple amdgcn--amdhsa -mcpu=$HSA_AMDGPU_GPU_TARGET -filetype=obj -o $1.hsail $1.opt.bc
if [ $KMDUMPISA == "1" ]; then
$HLC_LLC -O2 -mtriple amdgcn--amdhsa -mcpu=@HSA_AMDGPU_GPU_TARGET@ -filetype=asm -o $1.isa $1.opt.bc
$HLC_LLC -O2 -mtriple amdgcn--amdhsa -mcpu=$HSA_AMDGPU_GPU_TARGET -filetype=asm -o $1.isa $1.opt.bc
mv $1.isa ./dump.isa
fi
else
Expand Down