Revert "cmake: use HIP CONFIG on Windows" #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 41491c9. By the cmake documentation, Do not write find modules for packages that themselves build with CMake. Instead provide a CMake package configuration file with the package itself. HIP uses cmake to build. It should not have shipped a FindHIP.cmake (a cmake MODULE). A hip-config.cmake (a cmake CONFIG) is enough. We should use CONFIG on both Windows and GNU/Linux. Thus the commit needs to be reverted. Reference: https://cmake.org/cmake/help/latest/command/find_package.html Signed-off-by: Benda Xu <heroxbd@gentoo.org>
|
@evetsso would you please help review this commit? Thanks for your attention. Maybe I have missed an important point that a GNU/Linux hipFFT has to search for HIP by |
|
I see why it is the way it is at #66 (review) This merge request should be closed as a duplication of !66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 41491c9.
By the cmake documentation,
Do not write find modules for packages that themselves build with
CMake. Instead provide a CMake package configuration file with the
package itself.
HIP uses cmake to build. It should not have shipped a FindHIP.cmake (a cmake MODULE). A hip-config.cmake (a cmake CONFIG) is enough.
We should use CONFIG on both Windows and GNU/Linux. Thus the commit needs to be reverted.
Reference: https://cmake.org/cmake/help/latest/command/find_package.html
resolves #___
Summary of proposed changes: