[AMDGPU][WaveTransform] Update GCNLaneMaskUtils to make it use AMDGPULaneMaskConstants #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMDGPULaneMaskUtils This patch makes GCNLaneMaskUtils to use LaneMaskConstants defined by globally used AMDGPULaneMaskUtils, instead of GCNLaneMaskConstant eliminating the code duplication.
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/21 |
jmmartinez
approved these changes
Nov 3, 2025
cdevadas
reviewed
Nov 3, 2025
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/22 |
vg0204
force-pushed
the
amd/dev/vikashgu/incorporate-amdgpuLaneMaskUtils-into-gcnLaneMaskUtils
branch
from
c18db52 to
e024f0a
Compare
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/23 |
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/24 |
cdevadas
approved these changes
Nov 4, 2025
vg0204
deleted the
amd/dev/vikashgu/incorporate-amdgpuLaneMaskUtils-into-gcnLaneMaskUtils
branch
cdevadas
added a commit
that referenced
this pull request
Nov 4, 2025
cdevadas
added a commit
that referenced
this pull request
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes GCNLaneMaskUtils to use LaneMaskConstants defined by globally used AMDGPULaneMaskUtils, instead of GCNLaneMaskConstant eliminating the code duplication.