Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address and thread sanitizer fixes #250

Merged
merged 27 commits into from
Feb 27, 2023
Merged

Address and thread sanitizer fixes #250

merged 27 commits into from
Feb 27, 2023

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Feb 20, 2023 •
edited
Loading

  • Fix compilation with clang
  • Tweak perfetto copy to build tree
  • Added suppression files to scripts
  • fix LD_PRELOAD support in omnitrace-causal and omnitrace-sample
  • use spin_mutex and spin_lock from timemory instead of atomic_mutex and atomic_lock
  • state uses atomic
  • fix some memory leaks
  • tweak testing
    • mpi tests do not use preload
    • increase timeout when using sanitizers
    • add env LD_PRELOAD when using sanitizers
    • improve reliability for causal profiling end-to-end tests
  • improve fork handling, especially w.r.t. perfetto

@jrmadsen
Address and thread sanitizer fixes
0c9ddfb 
- Fix compilation with clang
- Tweak perfetto copy to build tree
- Added suppression files to scripts
- fix LD_PRELOAD support in omnitrace-causal and omnitrace-sample
- use spin_mutex and spin_lock from timemory instead of atomic_mutex and atomic_lock
- state uses atomic
- fix some memory leaks
- tweak testing
  - mpi tests do not use preload
  - increase timeout when using sanitizers
  - add env LD_PRELOAD when using sanitizers
@jrmadsen
Tweak perfetto build
ea85085
@jrmadsen
Update timemory submodule
258250a
@jrmadsen
Update version to 1.8.1
d1106b7
@jrmadsen
Update omnitrace-leak.supp
f5271d6
@jrmadsen jrmadsen added timemory Issue affects/involves timemory features/capabilities libomnitrace Involves omnitrace library testing Extends/improves/modifies testing submodule Updates a git submodule libomnitrace-core Internal library containing core capabilities labels Feb 20, 2023
@jrmadsen
Update timemory submodule
ba5f0f6 
- fixed spin_mutex implementation
@jrmadsen
Remove previously added addr_space->allowTraps(instr_traps)
4b62f2c 
- this appears to cause errors during binary rewrite
@jrmadsen
causal testing updates
21e4d4e 
- relaxed causal validation on CI systems (to account for hyperthreading decreasing prediction)
- improved impact calculation
- other general improvements to validate-causal-json.py
@jrmadsen
Improve fork handling for perfetto
a227e79 
- numerous updates changing perfetto:: to ::perfetto::
- added perfetto_fwd.hpp
@jrmadsen
Updated fork example
76a4ea7 
- user API for validation that stopping/starting perfetto is valid
@jrmadsen
Misc fixes to perfetto + fork support
84c1c14 
- tweak regions in fork example
- handle disabling tmp files
- get rid of stop/start with perfetto before/after fork
- fixed sampling support during fork
- tweak env of fork test
@jrmadsen
Fix find_package in build-tree
92af7a1
@jrmadsen
Fix buildtree export
4ebda94
@jrmadsen
Fix buildtree export
ad053b5
@jrmadsen
Restructured ConfigInstall before adding examples
f737307
@jrmadsen
Guard against creating tmp file in sampling when disabled
b494eb3
@jrmadsen
Fix buildtree package
08da35d
@jrmadsen
formatting
123ee5a
@jrmadsen
exit handlers on child processes
47b8e88 
- quick exit to avoid perfetto cleanup
@jrmadsen
Further tweaking of causal tests for reliability
1e32b09 
- enable PROCESSOR_AFFINITY
- decrease to 5 iterations
@jrmadsen
Further tweaking of causal tests for reliability
bf680c6 
- disable PROCESSOR_AFFINITY for fast func e2e tests
- enabling affinity results in (valid) speedup predictions greater than zero
@jrmadsen
Fixes to fork handling
ce99638 
- use pthread_atfork for redundancy if fork_gotcha fails
@jrmadsen
cmake formatting
5e27a48
@jrmadsen
Fix fork init settings + install components
8543f36 
- remove dl from PROJECT_BUILD_TARGETS
@jrmadsen
Testing tweaks
904ced0 
- fix mpi-binary-rewrite-run regex when OMNITRACE_VERBOSE set > 1 in env
- increase causal e2e iterations to 8
@jrmadsen
Fix "Test User API"
b05bf42 
- test-find-package.sh included dl component
@jrmadsen
Further tweaks to causal validation
d029669 
- further considerations of variance
@jrmadsen jrmadsen added cmake Modifies the CMake build system examples Adds new example or modifies existing example omnitrace-sample Involves the omnitrace-sample executable omnitrace-causal Involves the omnitrace-causal executable labels Feb 24, 2023
@jrmadsen jrmadsen merged commit 846301b into ROCm:main Feb 27, 2023
@jrmadsen jrmadsen deleted the address-and-thread-sanitizer-fixes branch February 27, 2023 18:09
This was referenced Mar 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cmake Modifies the CMake build system examples Adds new example or modifies existing example libomnitrace Involves omnitrace library libomnitrace-core Internal library containing core capabilities omnitrace-causal Involves the omnitrace-causal executable omnitrace-sample Involves the omnitrace-sample executable submodule Updates a git submodule testing Extends/improves/modifies testing timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen