Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address and thread sanitizer fixes #250

Merged
merged 27 commits into from
Feb 27, 2023

Commits on Feb 17, 2023

  1. Address and thread sanitizer fixes

    - Fix compilation with clang
    - Tweak perfetto copy to build tree
    - Added suppression files to scripts
    - fix LD_PRELOAD support in omnitrace-causal and omnitrace-sample
    - use spin_mutex and spin_lock from timemory instead of atomic_mutex and atomic_lock
    - state uses atomic
    - fix some memory leaks
    - tweak testing
      - mpi tests do not use preload
      - increase timeout when using sanitizers
      - add env LD_PRELOAD when using sanitizers
    jrmadsen committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    0c9ddfb View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Tweak perfetto build

    jrmadsen committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ea85085 View commit details
    Browse the repository at this point in the history
  2. Update timemory submodule

    jrmadsen committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    258250a View commit details
    Browse the repository at this point in the history
  3. Update version to 1.8.1

    jrmadsen committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    d1106b7 View commit details
    Browse the repository at this point in the history
  4. Update omnitrace-leak.supp

    jrmadsen committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    f5271d6 View commit details
    Browse the repository at this point in the history
  5. Update timemory submodule

    - fixed spin_mutex implementation
    jrmadsen committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ba5f0f6 View commit details
    Browse the repository at this point in the history
  6. Remove previously added addr_space->allowTraps(instr_traps)

    - this appears to cause errors during binary rewrite
    jrmadsen committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4b62f2c View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. causal testing updates

    - relaxed causal validation on CI systems (to account for hyperthreading decreasing prediction)
    - improved impact calculation
    - other general improvements to validate-causal-json.py
    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    21e4d4e View commit details
    Browse the repository at this point in the history
  2. Improve fork handling for perfetto

    - numerous updates changing perfetto:: to ::perfetto::
    - added perfetto_fwd.hpp
    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    a227e79 View commit details
    Browse the repository at this point in the history
  3. Updated fork example

    - user API for validation that stopping/starting perfetto is valid
    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    76a4ea7 View commit details
    Browse the repository at this point in the history
  4. Misc fixes to perfetto + fork support

    - tweak regions in fork example
    - handle disabling tmp files
    - get rid of stop/start with perfetto before/after fork
    - fixed sampling support during fork
    - tweak env of fork test
    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    84c1c14 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    92af7a1 View commit details
    Browse the repository at this point in the history
  6. Fix buildtree export

    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4ebda94 View commit details
    Browse the repository at this point in the history
  7. Fix buildtree export

    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    ad053b5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f737307 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b494eb3 View commit details
    Browse the repository at this point in the history
  10. Fix buildtree package

    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    08da35d View commit details
    Browse the repository at this point in the history
  11. formatting

    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    123ee5a View commit details
    Browse the repository at this point in the history
  12. exit handlers on child processes

    - quick exit to avoid perfetto cleanup
    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    47b8e88 View commit details
    Browse the repository at this point in the history
  13. Further tweaking of causal tests for reliability

    - enable PROCESSOR_AFFINITY
    - decrease to 5 iterations
    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    1e32b09 View commit details
    Browse the repository at this point in the history
  14. Further tweaking of causal tests for reliability

    - disable PROCESSOR_AFFINITY for fast func e2e tests
    - enabling affinity results in (valid) speedup predictions greater than zero
    jrmadsen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    bf680c6 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Fixes to fork handling

    - use pthread_atfork for redundancy if fork_gotcha fails
    jrmadsen committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    ce99638 View commit details
    Browse the repository at this point in the history
  2. cmake formatting

    jrmadsen committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    5e27a48 View commit details
    Browse the repository at this point in the history
  3. Fix fork init settings + install components

    - remove dl from PROJECT_BUILD_TARGETS
    jrmadsen committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8543f36 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Testing tweaks

    - fix mpi-binary-rewrite-run regex when OMNITRACE_VERBOSE set > 1 in env
    - increase causal e2e iterations to 8
    jrmadsen committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    904ced0 View commit details
    Browse the repository at this point in the history
  2. Fix "Test User API"

    - test-find-package.sh included dl component
    jrmadsen committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    b05bf42 View commit details
    Browse the repository at this point in the history
  3. Further tweaks to causal validation

    - further considerations of variance
    jrmadsen committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d029669 View commit details
    Browse the repository at this point in the history