Fix for empty #366
Merged
Fix for empty #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyreflectedinmirrors
requested review from
koomie and
coleramos425
as code owners
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18 Manifests as e.g.: ``` ERROR [analysis] 'float' object has no attribute 'empty' ``` because of: https://github.com/ROCm/omniperf/blob/d1ee2ec8709b21f2e72536cc14dba8ac2f8621ab/src/utils/parser.py#L135 Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
skyreflectedinmirrors
force-pushed
the
fix_for_empty
branch
from
564bc03 to
8fdfb23
Compare
coleramos425
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.