Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfixes for override arch option and deprecated python module #370

Merged
merged 7 commits into from
May 28, 2024
Merged

Hotfixes for override arch option and deprecated python module #370

merged 7 commits into from
May 28, 2024

Conversation

coleramos425
Copy link
Collaborator

@coleramos425 coleramos425 requested a review from koomie as a code owner May 28, 2024 20:24
skyreflectedinmirrors and others added 7 commits May 28, 2024 15:24
@skyreflectedinmirrors @coleramos425
Add ability to overide arch when name missing in rocminfo
bf9963b 
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>
@skyreflectedinmirrors @coleramos425
fix formatting
4a251d5 
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>
@coleramos425
handle unspecified case
db7d146 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
@coleramos425
Add fix for case where we pass a single 'nan' value to to_avg
0382638 
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18
Manifests as e.g.:

```
  ERROR [analysis] 'float' object has no attribute 'empty'
```

because of:

https://github.com/ROCm/omniperf/blob/d1ee2ec8709b21f2e72536cc14dba8ac2f8621ab/src/utils/parser.py#L135

Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
@coleramos425
Wrap text displayed in 'Top Dispatch' table for neatness
e01fc4e 
Signed-off-by: coleramos425 <colramos@amd.com>
@koomie @coleramos425
updated approach for runtime dependency check that does use "pkg_reso…
7885670 
…urces"

which will reportedly be deprecated at some point in the future.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
@koomie @coleramos425
remove use of distutils package entirely to avoid future deprecation
70f526e 
issues

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
@coleramos425 coleramos425 merged commit 7a01f49 into main May 28, 2024
9 of 10 checks passed
@coleramos425 coleramos425 deleted the hotfixes branch May 28, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koomie koomie Awaiting requested review from koomie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coleramos425 @skyreflectedinmirrors @koomie