Use Docker to setup development environment #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedithal-amd
requested review from
a team,
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
feizheng10
requested changes
Dec 19, 2024
There was a problem hiding this comment.
General speaking, one simple principle we might want to follow is: keep the individual files as less as possible. If the Dockerfile and docker-compose.yml file are only for "dev and quick testing", I'd suggest to move those to a sub_dir in tests(even though we don't have proper structure there yet). Think about we might provide official Dockerfile for the customer to build in the future, I don't want to confuse them later.
And this Dockerfile uses ubuntu-22.04 as base line, we should mention it in the readme.
vedithal-amd
force-pushed
the
vedithal/docker-env
branch
from
996ce2b to
855cf01
Compare
|
Thanks for the comment, Fei. I was thinking we should move the docker files to a subdir under utils instead of tests since these are technically utility files for the project, what do you think? |
vedithal-amd
force-pushed
the
vedithal/docker-env
branch
from
c578d79 to
e539e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.