fix(split links): adjust links editor properties for new MBS version #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 56 56
Lines 1258 1265 +7
Branches 197 198 +1
=======================================
+ Hits 1254 1261 +7
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
ROpdebee
force-pushed
the
multi-links-mbs-beta
branch
from
59dd9f8 to
06d406d
Compare
ROpdebee
changed the title
|
Since this has now landed in prod and it's a minor change, I'll merge without review. |
github-actions bot
added a commit
that referenced
this pull request
Jul 5, 2022
fix(split links): adjust links editor properties for new MBS version (#512)
|
🚀 Released 1 new userscript version(s):
|
ROpdebee
added a commit
that referenced
this pull request
Aug 8, 2022
PR #512 fixed it for the release editor, but broke it for artists etc. Turns out the MBS change there only applied to the release editor, the other pages weren't affected by the new property.
ROpdebee
added a commit
that referenced
this pull request
Aug 13, 2022
PR #512 fixed it for the release editor, but broke it for artists etc. Turns out the MBS change there only applied to the release editor, the other pages weren't affected by the new property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.metabrainz.org/t/ropdebees-userscripts-support-thread/551947/91
metabrainz/musicbrainz-server#2497 changed some internals that we were using to get the external links editor object (specifically, https://github.com/metabrainz/musicbrainz-server/pull/2497/files#diff-20a3affccc96c36d0a67c0ca98ebc7010590a1adc067eeea57147b0302bf1add).
This is only in beta for now, so for now we'll try both the fixed and old implementation and use the one that worked, but once this goes into prod we should remove the old implementation.