MBS-11599: Allow adding URL relationships to genre pages #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
modified the milestones:
Schema Change 2022 Q2,
Schema Change 2022 Q2 (implementation)
mwiencek
reviewed
Jun 8, 2022
Not implementing a full relationship editor yet since that has no easy React implementation and mwiencek is working on that for all entities, by which point it should be trivial to also extend it to genres. In the meantime, being able to link genres to Wikidata, Rate Your Music and whatnot seems like a great first step. We do need a "mock" relationship editor section for hidden inputs to be attached to, though, so one is added.
mwiencek
approved these changes
Jun 14, 2022
Co-authored-by: Michael Wiencek <mwtuea@gmail.com>
|
@brainzbot, retest this please |
yvanzo
reviewed
Jun 27, 2022
There was a problem hiding this comment.
Editing entity of other type with external link is not working anymore locally.
What I tried, using a local server, with a sample database, logged in as relationship editor:
- Adding an external link to a genre ✔️
- create a “test” Genre-URL relationship type
- edit the genre “classical”
- add the URL “
https://www.wikidata.org/wiki/Q1143752” as external link - check the edit has been successfully entered in edits history
- Adding an external link to an artist ❌
- edit the artist “Zachary Abels” (who has one artist relationship)
- add the URL “
https://www.wikidata.org/wiki/Q1143752” as external link too - check the edit has unfortunately not been entered in edits history
yvanzo
approved these changes
Jun 27, 2022
reosarevok
added a commit
that referenced
this pull request
Jun 28, 2022
* master: Update POT files using the production database Update translations from Transifex Rewrite "Test X" test names (#2575) Bump Flow to 0.181.1 MBS-12458: Error if trying to load annotation for wrong entity (#2568) MBS-11599: Allow adding URL relationships to genre pages (#2497) Fix the hydrate div name for AliasEditForm (#2490) Extend useful Controller::Ratings tests to other entities Document and standardize Controller::Tags tests
reosarevok
added a commit
that referenced
this pull request
Jul 3, 2022
* beta: Update POT files using the production database Update translations from Transifex MBS-12484: Hide genre alias edit links if limited (#2581) Update POT files using the production database Update translations from Transifex MBS-12459. Mimic native tooltip position offset (#2567) MBS-12472: Show genre edit history links for all users (#2574) Fix warning when displaying blank annotation text (#2578) Improve SQL formatting for language queries Add stat label for null language works MBS-12470: Fix work language query for null MBS-12470: Also list language = null in the stats page MBS-12470: Fix release language query for null Remove misleadingly-placed TODO MBS-12479: Add aliases for genres to the website MBS-12464: Also display event-work rels in Related Works (#2573) Remove seemingly useless test sql files (#2571) MBS-12474: Display Wikipedia extracts for genres (#2576) MBS-12475: Add autoselect for RYM genre URLs MBS-12475: Add autoselect for Wikidata genre URLs Update POT files using the production database Update translations from Transifex Rewrite "Test X" test names (#2575) Bump Flow to 0.181.1 MBS-12458: Error if trying to load annotation for wrong entity (#2568) MBS-11599: Allow adding URL relationships to genre pages (#2497) Fix the hydrate div name for AliasEditForm (#2490) Extend useful Controller::Ratings tests to other entities Document and standardize Controller::Tags tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-11599
Not implementing a full relationship editor yet since that has no easy React implementation and mwiencek is working on that for all entities, by which point it should be trivial to also extend it to genres. In the meantime, being able to link genres to Wikidata, Rate Your Music and whatnot seems like a great first step.
We do need a "mock" relationship editor section for hidden inputs to be attached to, though, so one is added.
On top of #2492