Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-12484: Fix genre alias edit links display #2581

Merged
merged 1 commit into from
Jul 2, 2022
Merged

MBS-12484: Fix genre alias edit links display #2581

merged 1 commit into from
Jul 2, 2022

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Jul 1, 2022

Problem: MBS-12484

Genre aliases page is showing edit links to non-privileged editors

Solution

Update the React component Aliases to handle genre the same as instrument.

Checklist for author

@yvanzo
MBS-12484: Hide genre alias edit links if limited
21eac6e 
Only the privileged “relationship editors” are allowed to edit genres
thus genre aliases. Edit links do not need to be shown otherwise as it
will just be returning an error page “Forbidden request”.
@yvanzo yvanzo added the Regression/Beta Bugs that are either on beta or new regressions and should be checked ASAP label Jul 1, 2022
@yvanzo yvanzo requested a review from reosarevok July 1, 2022 14:21
reosarevok
reosarevok approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yvanzo yvanzo merged commit 897b35c into metabrainz:beta Jul 2, 2022
@yvanzo yvanzo deleted the mbs-12484 branch July 2, 2022 11:38
reosarevok added a commit that referenced this pull request Jul 3, 2022
@reosarevok
Merge branch 'beta' into production
a381f15 
* beta:
  Update POT files using the production database
  Update translations from Transifex
  MBS-12484: Hide genre alias edit links if limited (#2581)
  Update POT files using the production database
  Update translations from Transifex
  MBS-12459. Mimic native tooltip position offset (#2567)
  MBS-12472: Show genre edit history links for all users (#2574)
  Fix warning when displaying blank annotation text (#2578)
  Improve SQL formatting for language queries
  Add stat label for null language works
  MBS-12470: Fix work language query for null
  MBS-12470: Also list language = null in the stats page
  MBS-12470: Fix release language query for null
  Remove misleadingly-placed TODO
  MBS-12479: Add aliases for genres to the website
  MBS-12464: Also display event-work rels in Related Works (#2573)
  Remove seemingly useless test sql files (#2571)
  MBS-12474: Display Wikipedia extracts for genres (#2576)
  MBS-12475: Add autoselect for RYM genre URLs
  MBS-12475: Add autoselect for Wikidata genre URLs
  Update POT files using the production database
  Update translations from Transifex
  Rewrite "Test X" test names (#2575)
  Bump Flow to 0.181.1
  MBS-12458: Error if trying to load annotation for wrong entity (#2568)
  MBS-11599: Allow adding URL relationships to genre pages (#2497)
  Fix the hydrate div name for AliasEditForm (#2490)
  Extend useful Controller::Ratings tests to other entities
  Document and standardize Controller::Tags tests
reosarevok added a commit that referenced this pull request Jul 7, 2022
@reosarevok
Merge branch 'production'
83391bb 
* production:
  Update POT files using the production database
  Update translations from Transifex
  MBS-12484: Hide genre alias edit links if limited (#2581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reosarevok reosarevok reosarevok approved these changes

Assignees
No one assigned
Labels
Regression/Beta Bugs that are either on beta or new regressions and should be checked ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvanzo @reosarevok