Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-12474: Display Wikipedia extracts for genres #2576

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

reosarevok
Copy link
Member

Implement MBS-12474

Plus a tiny preemptive bug fix where I had missed passing a prop.

@reosarevok reosarevok added the New feature Non urgent new stuff label Jun 28, 2022
This being missing would have broken annotation history links,
but since we have no genre annotations yet, it's not been an issue.
@reosarevok
Copy link
Member Author

@brainzbot, retest this please

Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMBDNT, just compared to the same code for areas. 🚢

@reosarevok reosarevok merged commit 8bdfeb4 into metabrainz:master Jun 29, 2022
@reosarevok reosarevok deleted the MBS-12474 branch June 29, 2022 13:56
reosarevok added a commit that referenced this pull request Jun 29, 2022
* master:
  Update POT files using the production database
  Update translations from Transifex
  MBS-12459. Mimic native tooltip position offset (#2567)
  MBS-12472: Show genre edit history links for all users (#2574)
  Fix warning when displaying blank annotation text (#2578)
  Improve SQL formatting for language queries
  Add stat label for null language works
  MBS-12470: Fix work language query for null
  MBS-12470: Also list language = null in the stats page
  MBS-12470: Fix release language query for null
  Remove misleadingly-placed TODO
  MBS-12479: Add aliases for genres to the website
  MBS-12464: Also display event-work rels in Related Works (#2573)
  Remove seemingly useless test sql files (#2571)
  MBS-12474: Display Wikipedia extracts for genres (#2576)
  MBS-12475: Add autoselect for RYM genre URLs
  MBS-12475: Add autoselect for Wikidata genre URLs
reosarevok added a commit that referenced this pull request Jul 3, 2022
* beta:
  Update POT files using the production database
  Update translations from Transifex
  MBS-12484: Hide genre alias edit links if limited (#2581)
  Update POT files using the production database
  Update translations from Transifex
  MBS-12459. Mimic native tooltip position offset (#2567)
  MBS-12472: Show genre edit history links for all users (#2574)
  Fix warning when displaying blank annotation text (#2578)
  Improve SQL formatting for language queries
  Add stat label for null language works
  MBS-12470: Fix work language query for null
  MBS-12470: Also list language = null in the stats page
  MBS-12470: Fix release language query for null
  Remove misleadingly-placed TODO
  MBS-12479: Add aliases for genres to the website
  MBS-12464: Also display event-work rels in Related Works (#2573)
  Remove seemingly useless test sql files (#2571)
  MBS-12474: Display Wikipedia extracts for genres (#2576)
  MBS-12475: Add autoselect for RYM genre URLs
  MBS-12475: Add autoselect for Wikidata genre URLs
  Update POT files using the production database
  Update translations from Transifex
  Rewrite "Test X" test names (#2575)
  Bump Flow to 0.181.1
  MBS-12458: Error if trying to load annotation for wrong entity (#2568)
  MBS-11599: Allow adding URL relationships to genre pages (#2497)
  Fix the hydrate div name for AliasEditForm (#2490)
  Extend useful Controller::Ratings tests to other entities
  Document and standardize Controller::Tags tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature Non urgent new stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants