Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-12311: Allow adding annotations to genres #2492

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

reosarevok
Copy link
Member

Implement MBS-12311

On top of #2487 and #2491

@reosarevok reosarevok added the New feature Non urgent new stuff label Apr 14, 2022
@reosarevok reosarevok added this to the Schema Change 2022 Q2 milestone Apr 14, 2022
@reosarevok reosarevok force-pushed the MBS-12311 branch 2 times, most recently from 78a551d to 9eea638 Compare April 19, 2022 16:41
@reosarevok reosarevok changed the base branch from schema-change-2022-q2 to master June 7, 2022 19:20
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket should at least mention that:

  • “Add genre annotation” edit type is added and searchable
  • Genre annotations are not searchable
    (along with a link to a SEARCH ticket)

LGTMBDNT otherwise!

@reosarevok reosarevok merged commit df414ca into metabrainz:master Jun 14, 2022
@reosarevok reosarevok deleted the MBS-12311 branch June 14, 2022 19:49
reosarevok added a commit that referenced this pull request Jun 14, 2022
* master:
  MBS-12311: Allow adding annotations to genres (#2492)
  Add basic genre create/edit tests
  Remove useless Area::Create _insert_hash
  MBS-10165: Use edit system for genre editing
  MBS-10165: Use edit system for genre adding
  MBS-10165: Use edit system for genre deletion
  MBS-10165: Basic preparations for genre edits
  Support genres in formatEntityTypeName
reosarevok added a commit that referenced this pull request Jun 20, 2022
* beta:
  Update translations from Transifex
  Add custom hydration event for userscripts (#2566)
  Update POT files using the production database
  Update translations from Transifex
  MBS-12311: Allow adding annotations to genres (#2492)
  Don't ISE on non-existing latest annotation
  MBS-12456: Load editor for latest_annotation on annotation page
  MBS-12455: Show annotation info when loading empty revision
  MBS-12453: Don't crash on null annotation comparison
  Use index, not ID, to enable/disable annotation comparison
  Add basic genre create/edit tests
  Update POT files using the production database
  Update translations from Transifex
  MBS-12395: Report for videos in mediums that shouldn't support video (#2562)
  MBS-12356: Correctly select + clean up Tidal store pages (#2515)
  Add comment to ensure test data is kept
  Save AC redirects before swapping AC uses
  Document and standardize Controller::Aliases tests
  Document and standardize Controller::EditAlias tests
  Document and standardize Controller::DeleteAlias tests
  Document and standardize Controller::AddAlias tests
  MBS-9188: Improve LinkedIn URL cleanup (#2553)
  MBS-12419: Block Genius.com links at release level (#2560)
  MBS-12417: Update Soundcloud cleanup to remove ? parameters (#2552)
  Avoid declaring my $tx twice in one test
  MBS-12351: Also trim space only disambiguations (#2510)
  MBS-12376: Don't show spammers on area pages (#2554)
  MBS-12447: Also show area-series rels on series page (#2563)
  MBS-12393: Change TOWER RECORDS to all-caps as per store Japanese usage (#2558)
  Remove useless Area::Create _insert_hash
  MBS-10165: Use edit system for genre editing
  MBS-10165: Use edit system for genre adding
  MBS-10165: Use edit system for genre deletion
  MBS-10165: Basic preparations for genre edits
  Support genres in formatEntityTypeName
  Simplify the allowed hosts shortener list
  MBS-12383: Block smart links: bfan.link
  MBS-12396: Block smart links: hyperfollow.com
  MBS-12401: Block smart links: hypeddit.com
  MBS-12350: Block smart links: bio.link
  MBS-12352: Block smart links: streamerlinks.com
  Add basic tests for the artist credit page
  Add IDs to sections of ArtistCreditIndex
  MBS-12354: Check if AC IDs are valid before passing to the DB
  MBS-12312: Convert edit.tt to React
  MBS-12312: Convert history.tt to React
  MBS-12312: Convert diff.tt to React
  MBS-12312: Convert revision.tt to React
  MBS-12312: Remove unused summary.tt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature Non urgent new stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants