Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct return in ppu_check #14404

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Direct return in ppu_check #14404

merged 1 commit into from
Aug 3, 2023

Conversation

cipherxof
Copy link
Contributor

@cipherxof cipherxof commented Jul 31, 2023

Should restore performance in MGS4 (~10% fps gain)

Addresses: #13638 (comment)

image

@AniLeo AniLeo requested review from Nekotekina and elad335 July 31, 2023 22:21
@solarmystic
Copy link

solarmystic commented Jul 31, 2023

Also restores lost performance in Persona 5 as well that happened due to the LLVM16 PR. #13638 (comment)

Latest master - 105 FPS
p5r latest master

PR Build - 110 FPS
p5r pr

@AniLeo AniLeo added CPU Optimization Optimizes existing code labels Jul 31, 2023
@Ordinary205
Copy link
Contributor

Can confirm that it doesn't have any performance regression on RDR.

14845: 26.9/28/28.7 FPS

Screenshot

RDR FPS TEST 3 (2)

14846: 25.8/26.5/27 FPS

Screenshot

RDR FPS TEST 2 (3)

PR: 28/29.1/30.1 FPS

Screenshot

RDR FPS TEST 1 (3)

@Nekotekina Nekotekina merged commit 0f3dfec into RPCS3:master Aug 3, 2023
@cipherxof cipherxof deleted the updates branch February 14, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPU Optimization Optimizes existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants