SPU/PPU LLVM: Fixups and minor optimizations

[elad335]

• Fix greedy PPU instruction search, there was a typo there and it was not considering BCLR and BCCTR.
• Add an optimization for PPU LLVM whener there are direct-unconditional branches following one another or ending up in an empty function (BLR).
• Add an optimization regarding PPU traps conditions, detect "always trap" forms and detect possible but theorectical simple "inequality" trap form. (either when both signed greater/lower or unsigned greater/lower are set).
• Improve SPU LLVM precompilation a bit.
• PPU LLVM: Patch unregistered BLRs.

May fix #14555
May fix #14600
May fix #14613

[elad335]

Caution: invalidates cache of some games.

[Nekotekina]

I didn't get why it's supposed to invalidate caches?

[elad335]

Because of the analyzer fixes.

[JimScript]

Hey, Jak and Daxter works again, even the savesates load now(and the precompiling is pretty fast too).
Edit: Well it looks like there's still a problem when going into a new area in a savestate, I get a black screen with a few:
E SYS: 'sys_fs_lseek' failed with 0x8001002a : CELL_EBADF
But I don't know if this relates to the problem at hand.
Edit2:Eh, it happens with both interpreters, so I'm guessing not.

[solarmystic]

Confirmed to fix #14600

Starting a New Game on a new profile works again.

[oltolm]

Clang produces warnings:

[94/535] Building CXX object rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/Cell/PPUAnalyser.cpp.obj
C:/src/rpcs3/rpcs3/Emu/Cell/PPUAnalyser.cpp:1891:31: warning: converting the enum constant to a boolean [-Wint-in-bool-context]
                                                        (type0 == ppu_itype::B || ppu_itype::BC) && target0 < segs[0].addr || target0 >= segs[0].addr + segs[0].size)
                                                                               ^
C:/src/rpcs3/rpcs3/Emu/Cell/PPUAnalyser.cpp:1891:49: warning: '&&' within '||' [-Wlogical-op-parentheses]
                                                        (type0 == ppu_itype::B || ppu_itype::BC) && target0 < segs[0].addr || target0 >= segs[0].addr + segs[0].size)
                                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ ~~
C:/src/rpcs3/rpcs3/Emu/Cell/PPUAnalyser.cpp:1891:49: note: place parentheses around the '&&' expression to silence this warning
                                                        (type0 == ppu_itype::B || ppu_itype::BC) && target0 < segs[0].addr || target0 >= segs[0].addr + segs[0].size)
                                                                                                 ^
                                                        (
                    )
2 warnings generated.

[oltolm]

Clang produces warnings:

[137/535] Building CXX object rpcs3/Emu/CMakeFiles/rpcs3_emu.dir/Cell/PPUThread.cpp.obj
C:/src/rpcs3/rpcs3/Emu/Cell/PPUThread.cpp:4724:23: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses]
                        if (func.size == 4 & !BLR_func && *info.get_ptr<u32>(func.addr) == ppu_instructions::BLR())
                            ~~~~~~~~~~~~~~~^
C:/src/rpcs3/rpcs3/Emu/Cell/PPUThread.cpp:4724:23: note: place parentheses around the '==' expression to silence this warning
                        if (func.size == 4 & !BLR_func && *info.get_ptr<u32>(func.addr) == ppu_instructions::BLR())
                                           ^
                            (             )
C:/src/rpcs3/rpcs3/Emu/Cell/PPUThread.cpp:4724:23: note: place parentheses around the & expression to evaluate it first
                        if (func.size == 4 & !BLR_func && *info.get_ptr<u32>(func.addr) == ppu_instructions::BLR())
                                           ^
                                         (            )
C:/src/rpcs3/rpcs3/Emu/Cell/PPUThread.cpp:4748:23: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses]
                        if (func.size == 4 & !BLR_func && *info.get_ptr<u32>(func.addr) == ppu_instructions::BLR())
                            ~~~~~~~~~~~~~~~^
C:/src/rpcs3/rpcs3/Emu/Cell/PPUThread.cpp:4748:23: note: place parentheses around the '==' expression to silence this warning
                        if (func.size == 4 & !BLR_func && *info.get_ptr<u32>(func.addr) == ppu_instructions::BLR())
                                           ^
                            (             )
C:/src/rpcs3/rpcs3/Emu/Cell/PPUThread.cpp:4748:23: note: place parentheses around the & expression to evaluate it first
                        if (func.size == 4 & !BLR_func && *info.get_ptr<u32>(func.addr) == ppu_instructions::BLR())
                                           ^
                                         (            )
2 warnings generated.

[nastys]

This seems to break the "Unlock all songs and modules" patch in Hatsune Miku: Project DIVA Dreamy Theater extend (and possibly others) when using PPU LLVM.