Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vision setting to New Map Preferences and New Map dialog. #1062

Closed
Phergus opened this issue Jan 1, 2020 · 3 comments
Closed

Add Vision setting to New Map Preferences and New Map dialog. #1062

Phergus opened this issue Jan 1, 2020 · 3 comments
Assignees
@emmebi
Labels
feature Adding functionality that adds value tested This issue has been QA tested by someone other than the developer.

Comments

@Phergus
Copy link
Contributor

Phergus commented Jan 1, 2020

Is your feature request related to a problem? Please describe.
Being able to set a Vision default (Off, Day, Night) for new maps would be convenient.

Describe the solution you'd like
Add a drop-down selector to both the Preference settings for New Map and also the New Map dialog.

Describe alternatives you've considered
Currently setting vision for a map is a separate menu action after adding a map.

Additional context
Forum post
@Phergus Phergus added the feature Adding functionality that adds value label Jan 1, 2020
@Phergus Phergus added the up for grabs Minimal context and are well-suited for new contributors label Jan 12, 2020
@emmebi
Copy link
Collaborator

emmebi commented Jan 18, 2020

I am starting working on this.

@Phergus Phergus removed the up for grabs Minimal context and are well-suited for new contributors label Jan 18, 2020
emmebi added a commit to emmebi/maptool that referenced this issue Jan 18, 2020
@emmebi
This allows to specify the default Light (Vision Type) which should b…
bac3a19 
…e used in new maps.

The Light value can be edited also when a new map is created or an existing one modified.

RPTools#1062
@emmebi emmebi mentioned this issue Jan 18, 2020
Merged
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Jan 19, 2020
@Phergus
Copy link
Contributor Author

Phergus commented Jan 19, 2020

Tested. Working as requested.

@Phergus Phergus added the documentation needed Missing, out-of-date or bad documentation label Jan 19, 2020
@Phergus
Copy link
Contributor Author

Phergus commented Jan 19, 2020

Wiki documentation added.

@Phergus Phergus removed the documentation needed Missing, out-of-date or bad documentation label Jan 19, 2020
Phergus added a commit that referenced this issue Jan 21, 2020
@Phergus
Update change log with latest changes
c9542de 
Added #353, #941, #1062, #1143, #1144, #1149, #1151
@Phergus Phergus mentioned this issue Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmebi emmebi

Labels
feature Adding functionality that adds value tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emmebi @JamzTheMan @Phergus