Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json.toList() is not removing quotes around strings #1143

Closed
Phergus opened this issue Jan 17, 2020 · 1 comment
Closed

json.toList() is not removing quotes around strings #1143

Phergus opened this issue Jan 17, 2020 · 1 comment
Assignees
@cwisniew
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Phergus
Copy link
Contributor

Phergus commented Jan 17, 2020

Describe the bug
json.toList() isn't removing the quotes around strings and is escaping quotes embedded in strings.

To Reproduce
Steps to reproduce the behavior:

[h: a = json.append("",'Some text with "quotes" in them',"And some more text.")]<br>
[r: json.toList(a,"")]

Produces:
"Some text with \"quotes\" in them","And some more text."

In 1.5.10 you get this:
Some text with "quotes" in themAnd some more text.

MapTool Info

  • Version: 1.5.11 dev and 1.6 alpha 4
@Phergus Phergus added bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Jan 17, 2020
@cwisniew cwisniew self-assigned this Jan 18, 2020
@cwisniew cwisniew mentioned this issue Jan 18, 2020
Merged
@Phergus
Copy link
Contributor Author

Phergus commented Jan 18, 2020

Tested. Working as expected.

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Jan 18, 2020
Phergus added a commit that referenced this issue Jan 21, 2020
@Phergus
Update change log with latest changes
c9542de 
Added #353, #941, #1062, #1143, #1144, #1149, #1151
@Phergus Phergus mentioned this issue Jan 21, 2020
Merged
@Phergus Phergus closed this as completed Jan 23, 2020
Merudo added a commit to Merudo/maptool that referenced this issue Jan 24, 2020
@Merudo
Add unit tests for recent json fixes
51928de 
- Add unit tests to prevent regressions of recent json bug fixes (RPTools#1121, RPTools#1125, RPTools#1139, RPTools#1143, RPTools#1144, RPTools#1151, RPTools#1167, RPTools#1177)
@Merudo Merudo mentioned this issue Jan 24, 2020
Merged
@Azhrei Azhrei mentioned this issue Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwisniew cwisniew

Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwisniew @Phergus