Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings containing numbers are trimmed when put in json #1139

Closed
Merudo opened this issue Jan 17, 2020 · 1 comment
Closed

Strings containing numbers are trimmed when put in json #1139

Merudo opened this issue Jan 17, 2020 · 1 comment
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Jan 17, 2020

Describe the bug
Strings containing a number surrounded by white spaces have their white spaces removed once put into a json object or array.

To Reproduce
Steps to reproduce the behavior:

  1. Type [r: json.append("[]", " 0 ")]
  2. The output on develop or 1.5.11 alpha 7: [0]
  3. The output for the same command on 1.5.10: [" 0 "]

Expected behavior
The behavior is the same as 1.5.10: the leading and trailing white spaces are not removed on 1.5.11.

MapTool Info

  • Version: 1.5.11 Alpha 7, develop (1/17/2020)
  • Install: New

Desktop (please complete the following information):

  • OS: Windows
  • Version: 10
@Phergus Phergus added bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Jan 17, 2020
@cwisniew cwisniew mentioned this issue Jan 17, 2020
Merged
@Phergus Phergus closed this as completed Jan 17, 2020
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Jan 17, 2020
@Phergus
Copy link
Contributor

Phergus commented Jan 17, 2020

Tested and working as expected.

Merudo added a commit to Merudo/maptool that referenced this issue Jan 24, 2020
@Merudo
Add unit tests for recent json fixes
51928de 
- Add unit tests to prevent regressions of recent json bug fixes (RPTools#1121, RPTools#1125, RPTools#1139, RPTools#1143, RPTools#1144, RPTools#1151, RPTools#1167, RPTools#1177)
@Merudo Merudo mentioned this issue Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus